Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a walk method #91

Closed
wants to merge 1 commit into from
Closed

Add a walk method #91

wants to merge 1 commit into from

Conversation

emilos
Copy link

@emilos emilos commented May 1, 2018

Hey,

thanks for the great lib 馃憤 . I was wondering if you'd mind adding a walk method to it. I'm using it in every project in which I use himalaya. Some parsers, like acorn, expose such methods for conveniance.

@coveralls
Copy link

coveralls commented May 1, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 5435721 on emilos:master into f0b8700 on andrejewski:master.

@andrejewski
Copy link
Owner

@emilos Thanks for the PR.

Tree walking can be pretty complex depending on what you want to do. Himalaya's API is intentionally very small so that layers can be built on top. I created paul to do different types of tree-walking when I first wrote Himalaya. I removed its usage just before v1 because it was not core functionality.

I recommend making a himalaya-walk package if you are interested, especially since you have tests and everything already.

I am closing this. I appreciate you taking the time to give back to the community, and hope Himalaya is working well for you.

@andrejewski andrejewski closed this May 2, 2018
@emilos
Copy link
Author

emilos commented May 2, 2018

@andrejewski thx, I totally understand what you mean, I thought it's better to ask first. I've published https://github.com/buxlabs/himalaya-walk for simple use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants