Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align runtime and React view functions #7

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Align runtime and React view functions #7

merged 1 commit into from
Jul 22, 2017

Conversation

andrejewski
Copy link
Owner

@andrejewski andrejewski commented Jul 22, 2017

The raj/runtime renderer should be called view. I think both words are vague enough and "renderer" makes Raj sound too cool and complicated. I have also flipped the call order of the renderer which was (dispatch, state) and now (state, dispatch). That was an ordering so poor, I even documented it wrong in the README originally.

This consistency is also important for me/library authors who now do not have to care about if people are using the raw runtime, React bindings, or something else. The view is the same everywhere.

@andrejewski andrejewski merged commit c1d27ef into master Jul 22, 2017
@andrejewski andrejewski deleted the all-view branch July 22, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant