Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project file in /home/ #392

Closed
osaund opened this issue Jul 16, 2021 · 4 comments · Fixed by #421
Closed

project file in /home/ #392

osaund opened this issue Jul 16, 2021 · 4 comments · Fixed by #421
Labels
bug Something isn't working released Feature/fix is released

Comments

@osaund
Copy link

osaund commented Jul 16, 2021

Any nitpick ROOT_FILES/PROJECT_FILES within the parent directory cause the app to use this as the project directory and thus config files are created in the wrong location.

I had a pipfile in my home directory that was causing the issue.

2021-07-16 11:40:28.389 | DEBUG | nitpick.project:find_root:81 - Project files seen: {PosixPath('/home/me/Pipfile'), PosixPath('/home/me/Pipfile.lock')}

My project directory was then set to /home/me rather than the correct place and where nitpick was run from /home/me/project

Why do we climb the file tree? Why not just use the current dir and fail if nothing is found? Push it back to the user rather mainting the overhead of trying to "find" the root

@osaund osaund added the bug Something isn't working label Jul 16, 2021
@andreoliwa
Copy link
Owner

Thanks for filing this bug.

You read my mind somehow.
There is a card about this: https://github.com/andreoliwa/nitpick/projects/1#card-59976086

Yes, climbing is not the ideal behaviour, I will change it.

@andreoliwa andreoliwa added this to Backlog in Nitpick Roadmap Jul 20, 2021
@1kyu
Copy link

1kyu commented Dec 8, 2021

But what about the default config file location like $HOME/.nitpick.toml and $HOME/.config/.nitpick.toml?

@andreoliwa
Copy link
Owner

But what about the default config file location like $HOME/.nitpick.toml and $HOME/.config/.nitpick.toml?

@1kyu this is an interesting idea, but it's not related to this bug.

I created a separate issue: #417
Take a look and check if it's what you originally thought; if not, drop a comment there.
Thanks!

@github-actions
Copy link

🎉 This issue has been resolved in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Feature/fix is released
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants