Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falsy values not properly compared #489

Open
mondeja opened this issue May 27, 2022 · 0 comments
Open

Falsy values not properly compared #489

mondeja opened this issue May 27, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mondeja
Copy link

mondeja commented May 27, 2022

Expected behavior

  • .nitpick.toml:
    [tool.nitpick]
    style = ["style.toml"]
  • style.toml
    ["foo.yaml"]
    boolean_true = true
    boolean_false = false
    string_a = 'string_a'
    string_b = 'string_b'
  • foo.yaml
    boolean_true: false
    boolean_false: true
    string_a: 'string_a'
    string_b: 'does not match'
$ nitpick check
foo.yaml:1: NIP369  has different values. Use this:
boolean_true: true
boolean_false: false
string_b: string_b

Current behavior

$ nitpick check
foo.yaml:1: NIP369  has different values. Use this:
boolean_true: true
string_b: string_b

Context

Your environment

  • nitpick version used: 0.32.0
  • Python version: 3.8.10
  • Operating System and version: All
@mondeja mondeja added the bug Something isn't working label May 27, 2022
@mondeja mondeja changed the title Falsy values don't properly compared Falsy values not properly compared May 30, 2022
@andreoliwa andreoliwa added this to Triage in Nitpick Roadmap Sep 18, 2022
@andreoliwa andreoliwa moved this from Triage to Upvoted / Requests in Nitpick Roadmap Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Upvoted / Requests
Nitpick Roadmap
  
Upvoted / Requests
Development

Successfully merging a pull request may close this issue.

1 participant