Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix to make compression of final image work #3

Merged
merged 1 commit into from Nov 12, 2021

Conversation

sekro
Copy link
Contributor

@sekro sekro commented Nov 12, 2021

No description provided.

@andreped
Copy link
Owner

@sekro could you try to find a solution to get JPEG compression to work in both stages?

I think most users are unable to use this solution as LZW produces too large WSIs, which does not scale well...

For instance, one of the images I have produces a BigTIFF of about 56 GB.

@andreped andreped added the bug Something isn't working label Nov 12, 2021
@sekro
Copy link
Contributor Author

sekro commented Nov 12, 2021

@andreped I ll look into it

@andreped
Copy link
Owner

andreped commented Nov 12, 2021

@sekro Thanks! As this solves the main issue, I will merge this PR.

Feel free to make a new one if you find a solution to the compression issue.

@andreped andreped closed this Nov 12, 2021
@andreped andreped reopened this Nov 12, 2021
@andreped andreped merged commit e808433 into andreped:main Nov 12, 2021
@sekro
Copy link
Contributor Author

sekro commented Nov 12, 2021

I did a little digging and it looks like this is an open issue of bioformats: ome/bioformats#3372
As far as I understand it produces JPEG compressed tiffs that use improper JPEG sampling factors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants