Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visits and events metrics #2

Merged
merged 2 commits into from
Sep 25, 2022
Merged

Add visits and events metrics #2

merged 2 commits into from
Sep 25, 2022

Conversation

francois2metz
Copy link
Contributor

The visits and events metrics are missing: https://plausible.io/docs/stats-api#metrics

I added the Visits metrics to the AllMetrics, but not the events one as it's not available on the timeseries API: https://plausible.io/docs/stats-api#get-apiv1statstimeseries

andrerfcsantos
andrerfcsantos approved these changes Sep 25, 2022
View reviewed changes
Copy link
Owner

@andrerfcsantos andrerfcsantos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

The only thing missing was to make de documentation in the README refer to these new metrics too, but I added those to the README.

@andrerfcsantos andrerfcsantos merged commit c17a4a5 into andrerfcsantos:main Sep 25, 2022
@francois2metz francois2metz deleted the add-events-visits-metrics branch September 25, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerfcsantos andrerfcsantos andrerfcsantos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francois2metz @andrerfcsantos