Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on parallel (Speed FTW) #40

Merged
merged 2 commits into from
Apr 13, 2019
Merged

Run tests on parallel (Speed FTW) #40

merged 2 commits into from
Apr 13, 2019

Conversation

andreroggeri
Copy link
Owner

No description provided.

@andreroggeri andreroggeri changed the title chore: Run tests on parallel (Speed FTW) Run tests on parallel (Speed FTW) Apr 13, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.087% when pulling 05b020f on speedup-ci-tests into b45e66b on master.

@andreroggeri
Copy link
Owner Author

From 211s to 56s on CI
From 21 to 7.5s on my machine

@andreroggeri andreroggeri merged commit 129144c into master Apr 13, 2019
@andreroggeri andreroggeri deleted the speedup-ci-tests branch April 13, 2019 15:25
@andreroggeri
Copy link
Owner Author

Side note: We were not mocking the discovery url requests, so every CI run we hit Nubank APIs with ~240 GET requests 🤦‍♂️

@andreroggeri
Copy link
Owner Author

Side note 2: After mocking the requests, I saw that this is creating a overhead... Without xdist it runs in 50ms and with it it runs in 5s 🤦‍♂️ 🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️🤦‍♂️

andreroggeri added a commit that referenced this pull request Apr 13, 2019
andreroggeri added a commit that referenced this pull request Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants