Allows customizing the textarea component used #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm trying to use your library using ClojureScript and Reagent. I have hit a simple yet annoying problem.
The Reagent library (which is a wrapper around React for cljs) needs to take special care with
textarea
components. It has to do with async rendering and caret positioning, and I won't go into details*. Long story short: for using your library I simply need to be able to use a customtextarea
component.I'm aware that this is a quite "specific" need, but it would make the library usable for anyone using reagent and maybe you can even think on other use cases for having a custom textarea component.
I could make it work with this quite simple changes that are in this PR. I wanted to ask you if you would be willing to accept those changes (I can add it to the docs and whatever change you may want).
Thanks!
*if you are curious, see madvas/cljs-react-material-ui#17 and reagent-project/reagent#265 (comment)