Relax omniauth oauth2 dependency #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 16, 2015 12:45
Omniauth-oauth2 dependency is set to `~> 1.1.1` which makes it impossible to upgrade to any other `omniauth-oauth2` version which is in the `1.x` release. Since `omniauth-oauth2` seems to be using semver this dependency can be relaxed, making it easier to upgrade gems when needed.
Gemfile.lock is supossed to be out of version control in gems.
| @@ -15,7 +15,7 @@ Gem::Specification.new do |gem| | |||
| gem.version = OmniAuth::Signnow::VERSION | |||
|
|
|||
| gem.add_dependency 'omniauth', '~> 1.0' | |||
| gem.add_dependency 'omniauth-oauth2', '~> 1.1.1' | |||
| gem.add_dependency 'omniauth-oauth2', '~> 1.1' | |||
There was a problem hiding this comment.
This is the important change here. It prevents any 1.x from being used with this gem, which makes it hard to keep dependencies up to date when using it.
|
Hello @andresbravog! Do you think this patch could be valuable for the gem? Would you mind merging/releasing it? Thanks! |
|
thx @franciscoj |
andresbravog
added a commit
that referenced
this pull request
Nov 18, 2015
Relax omniauth oauth2 dependency
You're welcome! Glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omniauth-oauth2dependency is set to~> 1.1.1which makes itimpossible to upgrade to any other
omniauth-oauth2version which is inthe
1.xrelease. Sinceomniauth-oauth2seems to be using semver thisdependency can be relaxed, making it easier to upgrade gems when needed.
I also fixed a failing spec and added some more modern rubies to the CI script.