This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
fixes #93 stop endless loop when node parent is null #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm always wary of merging this type of fixes. Adding safe checks around the code is just a patch, where the real problem is hiding somewhere else. The engine should never reach the HTML tag while scanning parents. I'll keep this pull open as a reminder and explore the real issue over the weekend. |
|
I completely agree with you about this being a patch more than a fix for the real bug, but not merging it means you leave the library with a bug that cause endless loop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added checking if node is null in the while condition