Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ON/OFF Not Working With GTK2 #8

Closed
ghost opened this issue May 24, 2014 · 7 comments
Closed

ON/OFF Not Working With GTK2 #8

ghost opened this issue May 24, 2014 · 7 comments

Comments

@ghost
Copy link

ghost commented May 24, 2014

Hi Andrew,

In Openbox I use this environment variable so that I can use GTK2 themes with QT5;

export QT_STYLE_OVERRIDE=gtk

WIth the QT theme under the Technologies you can click on the various names and they'll hightlight in blue and you can click and turn them on an off

Name   Type          Powered   Connected   Tethered
Wired   Ethernet     On          Yes         No

I noticed when using export QT_STYLE_OVERRIDE=gtk and then picking a GTK2 theme to use I can't click on any section and get them to highlight or get them to turn on or off, nothing happens.

Using export QT_STYLE_OVERRIDE=gtk and using GTK2 themes is breaking functionality.

@ghost
Copy link
Author

ghost commented Jun 5, 2014

Hi Andrew,

Well the buttons you've created now work with GTK2 themes, but the buttons should be made to match the look of the QT & GKT themes.

The buttons look like Tcl/Tk...

Cheers

@andrew-bibb
Copy link
Owner

They are not really buttons, rather they are labels I've duded out to look a bit like buttons. I'd say they work like buttons but they really don't, the QTableWidget that they live in processes the mouse click over the label making the label appear to act as a button. That is probably why they are working with the theme when others don't.

To add a real button adds enormously to the complexity of that widget, and I'd actually have to use a different (more complicated but more generic) base class which means rewriting a large section of code.

@ghost
Copy link
Author

ghost commented Jun 6, 2014

Hi Andrew,

Look don't take me wrong, I'm on your side you're doing a great job!

But as I said, this looks like Tcl/Tk and it looks out of place, really takes away from the aesthetics of the gui, so you don't want this.

The way you had it look originally in QT looked nice, but for some reason as I mentioned it wouldn't work with GKT2 themes, if it could of stayed the same where it just highlighted it, aesthetically speaking that was a lot nicer

@andrew-bibb
Copy link
Owner

No problems here. Just to make sure we're talking about the on/of buttons in the technology box on the first tab, right? I hope so as they are the only ones added recently.

The problem I've got is the table can contain widgets, but the documentation is very clear that they are to be used for static display only. There are no functions provided to do any sort of user interaction with them (believe me, I've looked). My button like labels was an attempt to code around that limitation. I've got it in the back of my mind that I'd also like to have a green and red golf ball as well as the text display in those fields, and I actually can't do that in a single label.

I'm thinking now of maybe putting in a custom push button that I derive from the standard push button. Push buttons can display both icons and text and should follow somewhat the theme styles. These controls are created dynamically, and they have to be because we don't know from moment to moment how many technologies will be found. In the custom button I can add a custom signal that can identify which dynamically created button sent the signal. Assuming I can get the tablewidget to ignore the mouse clicks on the pushbutton I should be able then link that button to the technology on/off function. Whew, sounds worse in writing than it really is.

@andrew-bibb
Copy link
Owner

Try out current git version 14.06.06-1. I'm skirting the line where I'm likely to be arrested for QTableWidget abuse.

@ghost
Copy link
Author

ghost commented Jun 7, 2014

Ohhh better watch it QT Police are going to get you! LOL...

YEAH this looks really nice now!

But I'm still noticing some goofy things going on with the buttons.

  1. The green on icons are positioned slightly to the right, click on and off a few times and you'll see they are over slightly to the right...
  2. Using default QT theme or GTK2, when clicking WiFI and it turns green, no WiFi SSID appear under the Services, also nothing appears under the Wireless tab.
  3. Using default QT theme or GTK2, when first starting cmst all I see under Technologies is Wired & Wifi, then when I click WiFi and it turns on, P2P will appear. Sometimes when I click WiFi off then P2P
    disappears. Since I see it disappear when I turn the WiFI off sometimes I'm assuming this is the normal behaviour? But most of the time when I click the WiFi off the P2P still remains.
  4. Using default QT theme or GTK2, I noticed sometimes when I click the WiFi off all the SSID still appear under the Services. I'm assuming when you click the WiFi off they should all dissappear, but sometimes they're not.

@ghost
Copy link
Author

ghost commented Jul 14, 2014

I guess I should of reported back you have this working... :)

Might as well close now... :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant