Refactor to use our tamagui wrapper instead of native-base #487

mbonete · 2023-11-11T16:04:32Z

Related to task:
https://github.com/users/andrew-bierman/projects/3/views/1?filterQuery=&pane=issue&itemId=34309618

cloudflare-pages · 2023-11-11T16:06:53Z

Deploying with Cloudflare Pages

Latest commit:	`6361623`
Status:	🚫 Build failed.

View logs

andrew-bierman · 2023-11-11T20:59:26Z

client/screens/feed/Feed.tsx

-        <HStack space={3} alignItems="center">
-          <Text
-            fontSize="lg"
-            fontWeight="bold"


we might want bold still

Thanks for the piece of feedback! I made that call while refactoring the design as I found the non-bold version closer to the apperance of the original view. I will put back the bold and prioritize keeping the HTML/design semantic over visual fidelity.

I like your thinking! that's a good thing to be aware of

…omponents

Refactor Card to use our tamagui wrapper instead of native-base

render · 2023-11-13T10:56:52Z

Your Render PR Server URL is https://packrat-dev-pr-487.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

render · 2023-11-13T11:11:32Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

render · 2023-11-13T15:49:47Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

render · 2023-11-13T21:24:13Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

andrew-bierman · 2023-11-14T03:23:40Z

Possible memory leak in the RStacks in FeedCard? Trying searching with search bar and see, super laggy for me and crashes. I narrowed it down to in here maybe ? But could use second opinion

This refactor only contains the first layer of the component. The component dependencies are still pending of refactor.

render · 2023-11-14T17:35:13Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

Refactors ProfileContainer, Settings and Avatar components. Adds headers components to packrat/ui

render · 2023-11-14T22:38:54Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

Updates the Dropdown and RSelect components. As we have kept the native version of the dropdown, I added a label to clarify the UI. Also, removed the internal state of RSelect so all the state is controlled from the outside.

render · 2023-11-15T13:08:31Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

Adds RCheckbox tamagui component

render · 2023-11-16T11:32:37Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

andrew-bierman · 2023-11-17T00:49:57Z

Dropping a comment as a reminder about memory leak / performance issue when using FeedCard. I think it's the 2 nested Stacks inside the card for some reason, but not 100%. Does not happen with native base weirdly.

render · 2023-12-27T14:53:34Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

render · 2023-12-28T03:14:10Z

Your Render PR Server at https://packrat-dev-pr-487.onrender.com is now live!

View it on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

… on web due to tamagui performance errors. Refactor to use pagination / cursors as well, tanstack virtual for web.

Feat/tamagui-rebase2

render · 2023-12-29T03:51:41Z

A deploy for your Render PR Server at https://packrat-dev-pr-487.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

…i-rebase2

Feat/tamagui rebase2

render · 2023-12-29T04:04:49Z

A deploy for your Render PR Server at https://packrat-dev-pr-487.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

render · 2023-12-29T05:22:16Z

A deploy for your Render PR Server at https://packrat-dev-pr-487.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

render · 2023-12-29T05:38:11Z

A deploy for your Render PR Server at https://packrat-dev-pr-487.onrender.com just failed.

View details on your dashboard at https://dashboard.render.com/web/srv-cl901sqvokcc73fvjkk0.

refactor(feed): changes native-base components for own tamagui wrapper

456f058

mbonete added the enhancement New feature or request label Nov 11, 2023

mbonete requested a review from andrew-bierman November 11, 2023 16:04

mbonete self-assigned this Nov 11, 2023

mbonete changed the base branch from main to andrew_testing November 11, 2023 16:05

andrew-bierman reviewed Nov 11, 2023

View reviewed changes

refactor(card): uses our own tamagui wrapper instead of native-base c…

2ed778e

…omponents

mbonete mentioned this pull request Nov 12, 2023

Refactor Card to use our tamagui wrapper instead of native-base #489

Merged

Merge pull request #489 from andrew-bierman/refactor/card-to-tamagui

f9ae085

Refactor Card to use our tamagui wrapper instead of native-base

refactor(FeedCard,DuplicateIcon): converts to tamagui

26309f8

mbonete added 2 commits November 13, 2023 23:09

fix(feed): reintroduces bold text

3a69a54

refactor(dropdown): makes it use tamagui instead of native-base

445e215

refactor(profilecontainer): transforms native-base to tamagui

bc1cb19

This refactor only contains the first layer of the component. The component dependencies are still pending of refactor.

mbonete added 2 commits November 15, 2023 00:21

refactor(select): capitalizes the text item

2bd6eef

refactor(profile): updates to tamagui based components

ca9621f

Refactors ProfileContainer, Settings and Avatar components. Adds headers components to packrat/ui

refactor(pack): changes native-base for tamagui based

2228beb

Updates the Dropdown and RSelect components. As we have kept the native version of the dropdown, I added a label to clarify the UI. Also, removed the internal state of RSelect so all the state is controlled from the outside.

refactor(packtable): converts native-base to tamagui based

02b0cfa

Adds RCheckbox tamagui component

mbonete marked this pull request as draft November 17, 2023 11:26

refactor(chatcontainer): partial refactor to tamagui

8d503a7

andrew-bierman added 2 commits December 26, 2023 22:26

restoring versions

03b1b24

regen lock

d8471f3

andrew-bierman added 2 commits December 27, 2023 22:02

fix on config, TODO - investigate babel issue with tamagui

4e42365

Merge branch 'feature/tamagui' into feat/tamagui-rebase2

4a01beb

andrew-bierman added 7 commits December 27, 2023 22:14

fix toast provider error

faf0f67

fix search input WIP

3df6a99

fix invalid text

2ee5d29

trying to fix items errors, WIP

ff7e5e3

TEMP FIX - switching large lists in feed and user data to be flatlist…

dd5e894

… on web due to tamagui performance errors. Refactor to use pagination / cursors as well, tanstack virtual for web.

git ignore tamagui config json

38d7171

Merge pull request #523 from andrew-bierman/feat/tamagui-rebase2

435886d

Feat/tamagui-rebase2

andrew-bierman added 3 commits December 28, 2023 22:55

removing bad import

499e75e

Merge remote-tracking branch 'origin/andrew_testing' into feat/tamagu…

1100d58

…i-rebase2

remove log

3099bc9

andrew-bierman marked this pull request as ready for review December 29, 2023 03:59

andrew-bierman added 2 commits December 28, 2023 23:02

Merge branch 'feature/tamagui' into feat/tamagui-rebase2

449c811

Merge pull request #531 from andrew-bierman/feat/tamagui-rebase2

0f7be2e

Feat/tamagui rebase2

andrew-bierman added 4 commits December 28, 2023 23:31

disabling toast

17a5089

disabling toast component

38219df

linting

f2df23c

quick fix on pack container select logic to use id

0f23dd2

fix lint error

6361623

andrew-bierman changed the title ~~Refactor Feed view to use our tamagui wrapper instead of native-base~~ Refactor to use our tamagui wrapper instead of native-base Dec 29, 2023

andrew-bierman merged commit a846069 into andrew_testing Dec 29, 2023
10 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor to use our tamagui wrapper instead of native-base #487

Refactor to use our tamagui wrapper instead of native-base #487

mbonete commented Nov 11, 2023

cloudflare-pages bot commented Nov 11, 2023 •

edited

andrew-bierman Nov 11, 2023

mbonete Nov 12, 2023

andrew-bierman Nov 14, 2023

render bot commented Nov 13, 2023

render bot commented Nov 13, 2023

render bot commented Nov 13, 2023

render bot commented Nov 13, 2023

andrew-bierman commented Nov 14, 2023

render bot commented Nov 14, 2023

render bot commented Nov 14, 2023

render bot commented Nov 15, 2023

render bot commented Nov 16, 2023

andrew-bierman commented Nov 17, 2023

render bot commented Dec 27, 2023

render bot commented Dec 28, 2023

render bot commented Dec 29, 2023

render bot commented Dec 29, 2023

render bot commented Dec 29, 2023

render bot commented Dec 29, 2023

Refactor to use our tamagui wrapper instead of native-base #487

Refactor to use our tamagui wrapper instead of native-base #487

Conversation

mbonete commented Nov 11, 2023

cloudflare-pages bot commented Nov 11, 2023 • edited

Deploying with Cloudflare Pages

andrew-bierman Nov 11, 2023

Choose a reason for hiding this comment

mbonete Nov 12, 2023

Choose a reason for hiding this comment

andrew-bierman Nov 14, 2023

Choose a reason for hiding this comment

render bot commented Nov 13, 2023

render bot commented Nov 13, 2023

render bot commented Nov 13, 2023

render bot commented Nov 13, 2023

andrew-bierman commented Nov 14, 2023

render bot commented Nov 14, 2023

render bot commented Nov 14, 2023

render bot commented Nov 15, 2023

render bot commented Nov 16, 2023

andrew-bierman commented Nov 17, 2023

render bot commented Dec 27, 2023

render bot commented Dec 28, 2023

render bot commented Dec 29, 2023

render bot commented Dec 29, 2023

render bot commented Dec 29, 2023

render bot commented Dec 29, 2023

cloudflare-pages bot commented Nov 11, 2023 •

edited