Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate leveldb-sys #3

Closed
skade opened this issue Mar 1, 2015 · 8 comments
Closed

Separate leveldb-sys #3

skade opened this issue Mar 1, 2015 · 8 comments

Comments

@skade
Copy link
Collaborator

skade commented Mar 1, 2015

Hi, I'm the author of the "leveldb" crate and just wanted to split out my FFI into leveldb-sys, finding out that you already released one ;).

You implementation is further ahead in terms of implemented functions and we use a few different strategies, but I don't think there is a major issue there.

Would you mind if I merged the two to share the effort in the future and maintained the sys version together?

FWIW, my implementation is here: https://github.com/skade/leveldb-sys/blob/master/src/lib.rs

@andrew-d
Copy link
Owner

@skade Wow, I totally didn't see this message at all - very sorry to have let this sit for literally months! Yeah, if you want to take over maintenance, I'd be happy to hand it over to you. Not sure how to do that for a Cargo crate, though 😕

@skade
Copy link
Collaborator Author

skade commented Jul 17, 2015

@andrew-d Hi!

http://doc.crates.io/crates-io.html "owner" is the subcommand you need. Just add cargo owner --add skade.

@andrew-d
Copy link
Owner

Okay, I added you to the owners of both the leveldb-sys and leveldb-rs crates, and also gave you access to this repo (if you need it for anything). Finally, there's a branch here with a build.rs that actually compiles and works (though, the tests on the main crate don't pass...)

@andrew-d
Copy link
Owner

Let me know if there's anything else you want me to do / anything I missed 😀

@skade
Copy link
Collaborator Author

skade commented Jul 17, 2015

I'll be in touch, I'll fly off to holidays in a few hours though, so I'm only going to check afterwards.

And thanks! 👍

@andrew-d
Copy link
Owner

No problem - enjoy your vacation! 😸

@skade
Copy link
Collaborator Author

skade commented Aug 1, 2015

I extracted leveldb-sys to: https://github.com/skade/leveldb-sys

@skade
Copy link
Collaborator Author

skade commented Mar 19, 2017

Removed leveldb-sys from leveldb-rs in version 0.0.6.

@skade skade closed this as completed Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants