Create a new SettingsManager. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
andrewbrereton
commented
Feb 6, 2024
andrewbrereton
commented
- Similar to Logger, it is a singleton.
- Implement it in ObsidianIcalPlugin so that it can be used anywhere.
- Change everywhere so that we are using the new getSetting and setSetting functions when we need to get the setting instead of passing arguments to parameters whenever we instantiate a class.
- Now SettingsManager acts as a cache layer between the application and the plugin saveData and loadData functions. Can add transformation and/or validation at a later stage if required.
- Fixes a bug where settings were not loading properly when new settings were added after a version upgrade.
- Fixes a bug where changing a value of a setting was not reflected throughout the code, requiring a restart of Obsidian.
…mplement it in ObsidianIcalPlugin so that it can be used anywhere. Change everywhere so that we are using the new getSetting and setSetting functions. Now SettingsManager acts as a cache layer between the application and the plugin saveData and loadData functions. Fixes a bug where settings were not loading properly when new settings were added after a version upgrade. Fixes a bug where changing a value of a setting was not reflected through the code.
…for each setting. Although this is more lines of code, it means that every setting is an explicit and strongly-typed property. Also modified instantiation so that the settings object is all you need to use the SettingsManager. Update settings implementation everywhere to use the new method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.