Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Employee Invitation: Using alpine js for role selection #57

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

margarizaldi
Copy link
Contributor

In my opinion, using livewire for updating visual appearance is not necessary, so using alpine must be better.

…ection

In my opinion, using livewire for updating visual appearance is not necessary, so using alpine must be better.
@andrewdwallo
Copy link
Owner

andrewdwallo commented Apr 3, 2023

In my opinion, using livewire for updating visual appearance is not necessary, so using alpine must be better.

Works great! I need to learn more alpine to be honest. Is there anything that needs to be updated in either the corresponding Action classes or the CompanyEmployeeManager.php Livewire component file? Will this affect any validation?

Also, if you are adding alpine here, might as well apply the same to the modal when editing a user's current role correct?

@margarizaldi
Copy link
Contributor Author

margarizaldi commented Apr 3, 2023

Is there anything that needs to be updated in either the corresponding Action classes or the CompanyEmployeeManager.php Livewire component file? Will this affect any validation?

I think there's nothing to do with the component. I just moved the DOM related task from the server to the browser. And the validation is still there, no touch.

Also, if you are adding alpine here, might as well apply the same to the modal when editing a user's current role correct?

Maybe tonight if I can I'll try....

@andrewdwallo
Copy link
Owner

andrewdwallo commented Apr 3, 2023

Sounds good, thanks! I already edited it in my current branch for the modal and works. Will wait on you.

Co-authored-by: Andrew Wallo <andrewdwallo@gmail.com>
@andrewdwallo andrewdwallo merged commit 7d03fdf into andrewdwallo:1.x Apr 3, 2023
@margarizaldi
Copy link
Contributor Author

margarizaldi commented Apr 3, 2023

Sounds good, thanks! I already edited it in my current branch for the modal and works. Will wait on you.

Hi sorry for my late response... And it's great to know that everything works... Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants