Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine Galaxy Side Commands to support galaxy plugins for data sources #1

Open
AndrewDWhite opened this issue Sep 16, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@AndrewDWhite
Copy link
Owner

AndrewDWhite commented Sep 16, 2022

Determine all of the Galaxy Side commands to support galaxy plugins as a source of game data.

Sample when there is no client response back:
{"id":"0","jsonrpc":"2.0","method":"get_capabilities","params":{}} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"} {"error":{"code":-32700,"message":"Parse error"},"id":null,"jsonrpc":"2.0"}
From a fresh reboot (already imported data) from the generic plugin.
plugin-test-97543122-7785-4444-2254-711233556699.log

@AndrewDWhite AndrewDWhite added the enhancement New feature or request label Sep 16, 2022
@AndrewDWhite
Copy link
Owner Author

Have added in some basic commands with no parsing for error responses. Currently waiting a second between calls and assuming it all goes fine. Not all calls are implemented as well. Also currently set to kill after making all known calls once.

@AndrewDWhite
Copy link
Owner Author

The current implementation has cause the need for #3 .

@AndrewDWhite
Copy link
Owner Author

@AndrewDWhite
Copy link
Owner Author

Some plugins also appear to require the commands to be awaited for their response.

https://github.com/UncleGoogle/galaxy-integration-humblebundle/blob/master/galaxy_emulator.py#L76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant