Update Confide to 4.x #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing over the templates from Confide as they are expecting the 'User' controller to be called 'Users', and this is not yet configurable. Change the login template to output the Confide facade's makeLoginForm method, to match behaviour of the other templates.
…in), port over stuff from git branching weirdness issue
…il the new created user if confide is set to do so. Remove unnecessary validation check at start of postEdit, fix type hinting in docblock, remove unused methods
This was referenced Dec 15, 2014
Closed
andrewelkins
added a commit
that referenced
this pull request
Dec 23, 2014
Update Confide to 4.x. This is great! Merging today. Thanks @chrispappas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconfigured the Bootstrap site to use the new Confide traits and Repositories, thanks to @nextpulse for the pointers in #401. Unit tests are all passing.
Comments welcome - this is my first PR in Github so I'm not 100% sure of the process.