Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement list objects v2 #168

Closed
gaul opened this issue Nov 12, 2016 · 4 comments
Closed

Implement list objects v2 #168

gaul opened this issue Nov 12, 2016 · 4 comments

Comments

@gaul
Copy link
Owner

gaul commented Nov 12, 2016

Breaks marker into continuation-token and start-after and adds fetch-owner option. Reference:

https://docs.aws.amazon.com/AmazonS3/latest/API/v2-RESTBucketGET.html

@Pluto1010
Copy link

Pluto1010 commented Jan 8, 2017

I would also be happy to this feature. I'm trying to enable my QNAP NAS to backup my data to B2 instead of Microsoft's Azure through s3proxy. I've tried accessing the storage through s3proxy using Cyberduck and learned that listing is not supported yet.

Can I help to do this?

I've also contacted QNAP support to add B2 support directly but it seemed that after a few mails they didn't even understand what I want. Instead of that they asked me what version of their backup tool I've installed on the NAS. Even their latest beta release does not support B2.

@gaul
Copy link
Owner Author

gaul commented Jan 8, 2017

@Pluto1010 Strange that Cyberduck does not fallback to list objects v1 when v2 emits NotImplemented; you should also follow up with its authors. I believe adding support for v2 is straightforward; S3Proxy has a limited notion of owner so simply fake that but you need to investigate the difference between marker and start-after. My intuition is that you just replace one with the other but this may have more subtlety.

@jumenzel
Copy link

jumenzel commented Nov 30, 2018

It would be great to add list objects v2 support to s3proxy. It appears though that jclouds does not support the continuation-token or know how to call s3 using the list-type=2 query parameter. So even if s3proxy supported list objects v2 it wouldn't really help. But I'm also new to this so maybe I've drawn the wrong conclusion. Any ideas?

@gaul
Copy link
Owner Author

gaul commented Jan 4, 2019

Sorry for my tardy response; I was traveling for several weeks. It looks like you implemented this in vyasa-analytics/s3proxy#1; could you submit a pull request here?

gaul added a commit that referenced this issue Feb 10, 2019
Not supporting fetch-owner until jclouds adds support for this.
Several applications like AWS CLI now require this RPC.  Fixes #168.
gaul added a commit that referenced this issue Feb 11, 2019
Not supporting fetch-owner until jclouds adds support for this.
Several applications like AWS CLI now require this RPC.  Fixes #168.
@gaul gaul closed this as completed in 3fed394 Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants