forked from django/django
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Async capable class based views #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They actually do as of this commit, and the middleware appears to work fine, but I'm sure there's some threading issues to be caught if nothing else.
Wrap sync calls in get_response (base handler and testcases)
andrewgodwin
force-pushed
the
async_views
branch
from
August 10, 2019 18:45
7a933d1
to
c6850f3
Compare
andrewgodwin
force-pushed
the
async_views
branch
from
September 26, 2019 17:11
c6850f3
to
2add2ab
Compare
andrewgodwin
force-pushed
the
async_views
branch
3 times, most recently
from
January 28, 2020 17:41
1df9d06
to
a22d053
Compare
andrewgodwin
force-pushed
the
async_views
branch
4 times, most recently
from
February 18, 2020 16:30
9ecc9b4
to
2c1d742
Compare
felixxm
force-pushed
the
async_views
branch
6 times, most recently
from
March 12, 2020 06:40
c637aef
to
f8d0904
Compare
carltongibson
force-pushed
the
async_views
branch
from
March 12, 2020 10:13
f8d0904
to
ce8cfbf
Compare
felixxm
force-pushed
the
async_views
branch
4 times, most recently
from
March 13, 2020 06:48
98c0367
to
342b68a
Compare
felixxm
force-pushed
the
async_views
branch
2 times, most recently
from
March 17, 2020 06:57
c3a94e3
to
c86f88b
Compare
carltongibson
force-pushed
the
async_views
branch
from
March 17, 2020 10:03
fe0ddbc
to
97ead93
Compare
felixxm
force-pushed
the
async_views
branch
2 times, most recently
from
March 18, 2020 18:59
40ca60c
to
fc0fa72
Compare
auvipy
suggested changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, can you fix the conflicts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.