Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom Classes per question #17

Open
VinSpee opened this issue Sep 4, 2015 · 7 comments
Open

custom Classes per question #17

VinSpee opened this issue Sep 4, 2015 · 7 comments

Comments

@VinSpee
Copy link

VinSpee commented Sep 4, 2015

I'd love to be able to use custom classes on a single question. is this possible? This is how I would expect it to work:

  }, {
    panelId : 'register-panel',
    panelHeader : 'My Awesome Form',
    panelText : 'We don\'t have a survey for you yet, how about we get you subscribed?',
    classes: {
      radioList : 'Field--paired Grid Grid--alignMiddle Grid--withGutters',
      radioListItem : 'Grid-cell u-size1of4'
    },
@andrewhathaway
Copy link
Owner

Completely possible.

I'm assuming this would override any previous question classes, not merge them?

@VinSpee
Copy link
Author

VinSpee commented Sep 4, 2015

That's what I had in mind

(null)

On Fri, Sep 4, 2015 at 5:27 PM, Andrew Hathaway notifications@github.com
wrote:

Completely possible.

I'm assuming this would override any previous question classes, not merge them?

Reply to this email directly or view it on GitHub:
#17 (comment)

@andrewhathaway
Copy link
Owner

Perfect. Will implement.

Appreciate the feedback and glad to see some use!

@VinSpee
Copy link
Author

VinSpee commented Sep 4, 2015

I'm in the middle of a prototype and this lib seems to tick all of the boxes for me. I started implementing it today - I'll be sure to file for things that I find I'm missing out on. Also the surface area is pretty small, so my might see a PR or two from me next week. 

Thanks for the great library, communication, and willingness to implement! 

(null)

On Fri, Sep 4, 2015 at 6:16 PM, Andrew Hathaway notifications@github.com
wrote:

Perfect. Will implement.

Appreciate the feedback and glad to see some use!

Reply to this email directly or view it on GitHub:
#17 (comment)

@andrewhathaway
Copy link
Owner

Perfect. Anything to make it better overall and become a major option for people to choose. The main aim is to make it fit anyones needs and have the flexibility to fit around their current systems etc,

You're very welcome!

@ericalli
Copy link

@andrewhathaway Just curious if this was ever implemented?

@andrewhathaway
Copy link
Owner

Hi @ericalli. Not as of yet, I was waiting for @VinSpee's PR!

I'll have to take some time to this done and fix a few more issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants