Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that all referenced types are included in dependency files #58

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

andrewhickman
Copy link
Owner

Fixes #57

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 78.74% and project coverage change: +0.14% 🎉

Comparison is base (1b97845) 76.19% compared to head (8e2292f) 76.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   76.19%   76.34%   +0.14%     
==========================================
  Files          31       31              
  Lines        5399     5457      +58     
==========================================
+ Hits         4114     4166      +52     
- Misses       1285     1291       +6     
Files Changed Coverage Δ
prost-reflect/src/descriptor/mod.rs 65.00% <ø> (ø)
prost-reflect/tests/main.rs 100.00% <ø> (ø)
prost-reflect/src/descriptor/build/resolve.rs 68.11% <76.31%> (+0.70%) ⬆️
prost-reflect/src/descriptor/build/options.rs 64.74% <76.92%> (+1.87%) ⬆️
prost-reflect/src/descriptor/error.rs 54.46% <81.25%> (+1.15%) ⬆️
prost-reflect/src/descriptor/build/mod.rs 96.87% <85.00%> (-3.13%) ⬇️
prost-reflect/src/descriptor/build/names.rs 66.82% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhickman andrewhickman merged commit 9a81cc2 into main Sep 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect name resolution when files aren't imported
1 participant