Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples and Vignette updated #30

Merged
merged 48 commits into from
Sep 3, 2018
Merged

Conversation

martin-gmx
Copy link
Contributor

Hi Andy
We have now updated the examples and the vignette.
Over to you
Martin

giulialestini and others added 30 commits February 15, 2018 15:35
…g the file "intro-poped.Rmd" into a user-friendly readable docunment "html_vignette"
…nction in the example.7PK1.comp.maturation. Update also the intro-poped.Rmd with new examples
…th_iov.R". The latter has a bug that needs to be fixed. The examples are also reported in the vignette.
# Conflicts:
#	vignettes/intro-poped.html
#	vignettes/intro-poped_files/figure-html/simulate_with_BSV-1.png
#	vignettes/intro-poped_files/figure-html/unnamed-chunk-12-1.png
#	vignettes/intro-poped_files/figure-html/unnamed-chunk-14-1.png
#	vignettes/intro-poped_files/figure-html/unnamed-chunk-6-1.png
#	vignettes/intro-poped_files/figure-html/unnamed-chunk-9-1.png
Conflicts resolved:
	vignettes/intro-poped.html
	vignettes/intro-poped_files/figure-html/unnamed-chunk-9-1.png
Merge branch 'master' into examples

Conflicts:
	DESCRIPTION
	vignettes/intro-poped.html
	vignettes/intro-poped_files/figure-html/simulate_with_BSV-1.png
	vignettes/intro-poped_files/figure-html/unnamed-chunk-12-1.png
	vignettes/intro-poped_files/figure-html/unnamed-chunk-14-1.png
	vignettes/intro-poped_files/figure-html/unnamed-chunk-6-1.png
	vignettes/intro-poped_files/figure-html/unnamed-chunk-9-1.png
@codecov
Copy link

codecov bot commented Jul 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@e2c2bc3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   49.68%           
=========================================
  Files             ?      134           
  Lines             ?     9191           
  Branches          ?        0           
=========================================
  Hits              ?     4567           
  Misses            ?     4624           
  Partials          ?        0
Impacted Files Coverage Δ
R/inv.R 93.33% <100%> (ø)
R/evaluate_power.R 86.95% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2c2bc3...6c53b72. Read the comment docs.

Copy link
Owner

@andrewhooker andrewhooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should min_n only be calculated if you are not using a prior FIM. What is the reasoning?

@andrewhooker andrewhooker merged commit 2647191 into andrewhooker:master Sep 3, 2018
@andrewhooker
Copy link
Owner

Thanks again for your hard work!

@martin-gmx martin-gmx deleted the examples branch September 14, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants