Remove icon and update text for 0%

andrewiggins · Dec 6, 2020 · 55b9089 · 55b9089
1 parent b63bbca
commit 55b9089
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dist/util.js b/dist/util.js
@@ -8246,7 +8246,7 @@ function formatDifference({ absolute, percentChange: relative }) {
 		// show 0% - 0% but the actual result is actually not zero (i.e. -0.5% to
 		// 0.4%) let's still show the result as unsure to avoid a situation where we
 		// would display something like "slower ❌ 0% - 0% (0.00ms - 0.00ms)"
-		word = `<strong>unsure ❔</strong>`; // bold blue
+		word = `<strong>same</strong>`; // bold blue
 		rel = formatConfidenceInterval(relative, (n) => colorizeSign(n, percent));
 		abs = formatConfidenceInterval(absolute, (n) => colorizeSign(n, milli));
 	} else if (absolute.low > 0 && relative.low > 0) {

diff --git a/src/utils/tachometer.js b/src/utils/tachometer.js
@@ -132,7 +132,7 @@ function formatDifference({ absolute, percentChange: relative }) {
 		// show 0% - 0% but the actual result is actually not zero (i.e. -0.5% to
 		// 0.4%) let's still show the result as unsure to avoid a situation where we
 		// would display something like "slower ❌ 0% - 0% (0.00ms - 0.00ms)"
-		word = `<strong>unsure ❔</strong>`; // bold blue
+		word = `<strong>same</strong>`; // bold blue
 		rel = formatConfidenceInterval(relative, (n) => colorizeSign(n, percent));
 		abs = formatConfidenceInterval(absolute, (n) => colorizeSign(n, milli));
 	} else if (absolute.low > 0 && relative.low > 0) {

diff --git a/tests/getCommentBody.test.js b/tests/getCommentBody.test.js
@@ -377,11 +377,11 @@ newCommentSuite("Shows unsure if change is 0% - 0%", async () => {
 	const summaryId = getSummaryId({ reportId });
 	const actual = html.querySelector(`#${summaryId}`).text;
 	const expected =
-		"report-id: unsure ❔ -0% - -0% (-0.00ms - -0.00ms)local-framework vs base-framework";
+		"report-id: same -0% - -0% (-0.00ms - -0.00ms)local-framework vs base-framework";
 	assert.equal(
 		actual,
 		expected,
-		"Expected unsure to show for rounded 0% difference"
+		"Expected same to show for rounded 0% difference"
 	);
 });