Merge c0fec66 into 0911714

andrewiggins · Dec 8, 2020 · 9d594a4 · 9d594a4
2 parents 0911714 + c0fec66
commit 9d594a4
Show file tree

Hide file tree

Showing 16 changed files with 73 additions and 61 deletions.
diff --git a/README.md b/README.md
@@ -128,9 +128,9 @@ measurement names (e.g. `measure1, measure2`) to include in the summary.
 ![Picture of a PR comment with icons indicating in progress benchmarks](./docs/in-progress-comment-with-results.png)
 
 If the `report-id` option is provided, then `tachometer-reporter-action` will
-add a stopwatch icon (⏱) next to any benchmark that is currently running. If the
-action can determine the current job id, then the icon is a link to the action
-job that is running the benchmark (see #7).
+add an hourglass icon (⏳) next to any benchmark that is currently running. If
+the action can determine the current job id, then the icon is a link to the
+action job that is running the benchmark (see #7).
 
 ### Multiple measurements in one benchmark
 

diff --git a/dist/util.js b/dist/util.js
@@ -8243,10 +8243,10 @@ function formatDifference({ absolute, percentChange: relative }) {
 	let word, rel, abs;
 	if (Math.round(relative.low) == 0 && Math.round(relative.high) == 0) {
 		// Our formatting for percents uses `.toFixed(0)`. In cases where we would
-		// show 0% - 0% but the actual result is actually not zero (i.e. -0.5 - 0.4)
-		// let's still show the result as unsure to avoid a situation where we would
-		// display something like "slower ❌ 0% - 0% (0.00ms - 0.00ms)"
-		word = `<strong>unsure 🔍</strong>`; // bold blue
+		// show 0% - 0% but the actual result is actually not zero (i.e. -0.5% to
+		// 0.4%) let's still show the result as unsure to avoid a situation where we
+		// would display something like "slower ❌ 0% - 0% (0.00ms - 0.00ms)"
+		word = `<strong>same</strong>`; // bold blue
 		rel = formatConfidenceInterval(relative, (n) => colorizeSign(n, percent));
 		abs = formatConfidenceInterval(absolute, (n) => colorizeSign(n, milli));
 	} else if (absolute.low > 0 && relative.low > 0) {
@@ -8258,7 +8258,7 @@ function formatDifference({ absolute, percentChange: relative }) {
 		rel = formatConfidenceInterval(negate(relative), percent);
 		abs = formatConfidenceInterval(negate(absolute), milli);
 	} else {
-		word = `<strong>unsure 🔍</strong>`; // bold blue
+		word = `<strong>unsure ❔</strong>`; // bold blue
 		rel = formatConfidenceInterval(relative, (n) => colorizeSign(n, percent));
 		abs = formatConfidenceInterval(absolute, (n) => colorizeSign(n, milli));
 	}
@@ -8678,7 +8678,7 @@ function Status({ actionInfo, icon }) {
 		"aria-label": icon ? label : null,
 	};
 
-	return h(tag, props, icon ? "⏱ " : label);
+	return h(tag, props, icon ? "⏳ " : label);
 }
 
 /**

diff --git a/src/getCommentBody.js b/src/getCommentBody.js
@@ -263,7 +263,7 @@ function Status({ actionInfo, icon }) {
 		"aria-label": icon ? label : null,
 	};
 
-	return h(tag, props, icon ? "⏱ " : label);
+	return h(tag, props, icon ? "⏳ " : label);
 }
 
 /**

diff --git a/src/utils/tachometer.js b/src/utils/tachometer.js
@@ -129,10 +129,10 @@ function formatDifference({ absolute, percentChange: relative }) {
 	let word, rel, abs;
 	if (Math.round(relative.low) == 0 && Math.round(relative.high) == 0) {
 		// Our formatting for percents uses `.toFixed(0)`. In cases where we would
-		// show 0% - 0% but the actual result is actually not zero (i.e. -0.5 - 0.4)
-		// let's still show the result as unsure to avoid a situation where we would
-		// display something like "slower ❌ 0% - 0% (0.00ms - 0.00ms)"
-		word = `<strong>unsure 🔍</strong>`; // bold blue
+		// show 0% - 0% but the actual result is actually not zero (i.e. -0.5% to
+		// 0.4%) let's still show the result as unsure to avoid a situation where we
+		// would display something like "slower ❌ 0% - 0% (0.00ms - 0.00ms)"
+		word = `<strong>same</strong>`; // bold blue
 		rel = formatConfidenceInterval(relative, (n) => colorizeSign(n, percent));
 		abs = formatConfidenceInterval(absolute, (n) => colorizeSign(n, milli));
 	} else if (absolute.low > 0 && relative.low > 0) {
@@ -144,7 +144,7 @@ function formatDifference({ absolute, percentChange: relative }) {
 		rel = formatConfidenceInterval(negate(relative), percent);
 		abs = formatConfidenceInterval(negate(absolute), milli);
 	} else {
-		word = `<strong>unsure 🔍</strong>`; // bold blue
+		word = `<strong>unsure ❔</strong>`; // bold blue
 		rel = formatConfidenceInterval(relative, (n) => colorizeSign(n, percent));
 		abs = formatConfidenceInterval(absolute, (n) => colorizeSign(n, milli));
 	}

diff --git a/tests/fixtures/multi-measure-results-running.html b/tests/fixtures/multi-measure-results-running.html
@@ -19,7 +19,7 @@ <h4>duration</h4>
 								href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 								title="Currently running in Pull Request Test #50…"
 								aria-label="Currently running in Pull Request Test #50…"
-								>⏱
+								>⏳
 							</a></span
 						>multi-measure-report-id: <strong>faster ✔</strong>
 						<em>4% - 8% (6.30ms - 13.34ms)</em><br /><sup
@@ -45,7 +45,7 @@ <h4>window.usedJSHeapSize</h4>
 								href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 								title="Currently running in Pull Request Test #50…"
 								aria-label="Currently running in Pull Request Test #50…"
-								>⏱
+								>⏳
 							</a></span
 						>multi-measure-report-id: <strong>slower ❌</strong>
 						<em>91% - 91% (3.25ms - 3.26ms)</em><br /><sup
@@ -71,7 +71,7 @@ <h3>Results</h3>
 							href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 							title="Currently running in Pull Request Test #50…"
 							aria-label="Currently running in Pull Request Test #50…"
-							>⏱
+							>⏳
 						</a></span
 					><strong>multi-measure-report-id</strong></summary
 				>

diff --git a/tests/fixtures/multi-measure-running.html b/tests/fixtures/multi-measure-running.html
@@ -18,7 +18,7 @@ <h3>Summary</h3>
 								href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 								title="Currently running in Pull Request Test #50…"
 								aria-label="Currently running in Pull Request Test #50…"
-								>⏱
+								>⏳
 							</a></span
 						>multi-measure-report-id
 					</div>
@@ -41,7 +41,7 @@ <h3>Results</h3>
 							href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 							title="Currently running in Pull Request Test #50…"
 							aria-label="Currently running in Pull Request Test #50…"
-							>⏱
+							>⏳
 						</a></span
 					><strong>multi-measure-report-id</strong></summary
 				>

diff --git a/tests/fixtures/multiple-entries.html b/tests/fixtures/multiple-entries.html
@@ -13,7 +13,7 @@ <h3>Summary</h3>
 						class="summary::report-id"
 						data-run-number="50"
 					>
-						<span class="status"></span>report-id: <strong>unsure 🔍</strong>
+						<span class="status"></span>report-id: <strong>unsure ❔</strong>
 						<em>-10% - +12% (-4.10ms - +5.24ms)</em><br /><sup
 							>local-framework vs base-framework</sup
 						>
@@ -26,7 +26,7 @@ <h3>Summary</h3>
 						data-run-number="50"
 					>
 						<span class="status"></span>test-results-new-id:
-						<strong>unsure 🔍</strong> <em>-21% - +2% (-10.34ms - +1.15ms)</em
+						<strong>unsure ❔</strong> <em>-21% - +2% (-10.34ms - +1.15ms)</em
 						><br /><sup>local-framework vs base-framework</sup>
 					</div>
 				</li>
@@ -90,7 +90,7 @@ <h3>Results</h3>
 								</td>
 								<td align="center">-</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-12% - +9%<br />-5.24ms -
+									<strong>unsure ❔</strong><br />-12% - +9%<br />-5.24ms -
 									+4.10ms
 								</td>
 							</tr>
@@ -101,7 +101,7 @@ <h3>Results</h3>
 									<strong>slower ❌</strong><br />9% - 38%<br />3.55ms - 12.77ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-10% - +12%<br />-4.10ms -
+									<strong>unsure ❔</strong><br />-10% - +12%<br />-4.10ms -
 									+5.24ms
 								</td>
 								<td align="center">-</td>
@@ -157,11 +157,11 @@ <h3>Results</h3>
 									18.26ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-1% - +26%<br />-0.40ms -
+									<strong>unsure ❔</strong><br />-1% - +26%<br />-0.40ms -
 									+10.72ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-3% - +24%<br />-1.15ms -
+									<strong>unsure ❔</strong><br />-3% - +24%<br />-1.15ms -
 									+10.34ms
 								</td>
 							</tr>
@@ -173,11 +173,11 @@ <h3>Results</h3>
 								</td>
 								<td align="center">-</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-22% - -0%<br />-10.72ms -
+									<strong>unsure ❔</strong><br />-22% - -0%<br />-10.72ms -
 									+0.40ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-12% - +9%<br />-5.24ms -
+									<strong>unsure ❔</strong><br />-12% - +9%<br />-5.24ms -
 									+4.10ms
 								</td>
 							</tr>
@@ -188,12 +188,12 @@ <h3>Results</h3>
 									<strong>slower ❌</strong><br />9% - 38%<br />3.55ms - 12.77ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-21% - +2%<br />-10.34ms -
+									<strong>unsure ❔</strong><br />-21% - +2%<br />-10.34ms -
 									+1.15ms
 								</td>
 								<td align="center">-</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-10% - +12%<br />-4.10ms -
+									<strong>unsure ❔</strong><br />-10% - +12%<br />-4.10ms -
 									+5.24ms
 								</td>
 							</tr>

diff --git a/tests/fixtures/new-comment-running.html b/tests/fixtures/new-comment-running.html
@@ -18,7 +18,7 @@ <h3>Summary</h3>
 								href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 								title="Currently running in Pull Request Test #50…"
 								aria-label="Currently running in Pull Request Test #50…"
-								>⏱
+								>⏳
 							</a></span
 						>report-id
 					</div>
@@ -41,7 +41,7 @@ <h3>Results</h3>
 							href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 							title="Currently running in Pull Request Test #50…"
 							aria-label="Currently running in Pull Request Test #50…"
-							>⏱
+							>⏳
 						</a></span
 					><strong>report-id</strong></summary
 				>

diff --git a/tests/fixtures/test-results-2-updated-comment.html b/tests/fixtures/test-results-2-updated-comment.html
@@ -13,7 +13,7 @@ <h3>Summary</h3>
 						class="summary::JQx4P-VUyiFWEMlMIUU5w9uyy6s"
 						data-run-number="50"
 					>
-						<span class="status"></span>test_bench: <strong>unsure 🔍</strong>
+						<span class="status"></span>test_bench: <strong>unsure ❔</strong>
 						<em>-11% - +13% (-5.10ms - +6.24ms)</em><br /><sup
 							>local-framework vs base-framework</sup
 						>
@@ -79,7 +79,7 @@ <h3>Results</h3>
 								</td>
 								<td align="center">-</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-13% - +10%<br />-6.24ms -
+									<strong>unsure ❔</strong><br />-13% - +10%<br />-6.24ms -
 									+5.10ms
 								</td>
 							</tr>
@@ -91,7 +91,7 @@ <h3>Results</h3>
 									13.77ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-11% - +13%<br />-5.10ms -
+									<strong>unsure ❔</strong><br />-11% - +13%<br />-5.10ms -
 									+6.24ms
 								</td>
 								<td align="center">-</td>

diff --git a/tests/fixtures/test-results-body.html b/tests/fixtures/test-results-body.html
@@ -43,7 +43,7 @@
 				</td>
 				<td align="center">-</td>
 				<td align="center">
-					<strong>unsure 🔍</strong><br />-12% - +9%<br />-5.24ms - +4.10ms
+					<strong>unsure ❔</strong><br />-12% - +9%<br />-5.24ms - +4.10ms
 				</td>
 			</tr>
 			<tr>
@@ -53,7 +53,7 @@
 					<strong>slower ❌</strong><br />9% - 38%<br />3.55ms - 12.77ms
 				</td>
 				<td align="center">
-					<strong>unsure 🔍</strong><br />-10% - +12%<br />-4.10ms - +5.24ms
+					<strong>unsure ❔</strong><br />-10% - +12%<br />-4.10ms - +5.24ms
 				</td>
 				<td align="center">-</td>
 			</tr>

diff --git a/tests/fixtures/test-results-existing-comment.html b/tests/fixtures/test-results-existing-comment.html
@@ -13,7 +13,7 @@ <h3>Summary</h3>
 						class="summary::report-id"
 						data-run-number="50"
 					>
-						<span class="status"></span>report-id: <strong>unsure 🔍</strong>
+						<span class="status"></span>report-id: <strong>unsure ❔</strong>
 						<em>-10% - +12% (-4.10ms - +5.24ms)</em><br /><sup
 							>local-framework vs base-framework</sup
 						>
@@ -79,7 +79,7 @@ <h3>Results</h3>
 								</td>
 								<td align="center">-</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-12% - +9%<br />-5.24ms -
+									<strong>unsure ❔</strong><br />-12% - +9%<br />-5.24ms -
 									+4.10ms
 								</td>
 							</tr>
@@ -90,7 +90,7 @@ <h3>Results</h3>
 									<strong>slower ❌</strong><br />9% - 38%<br />3.55ms - 12.77ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-10% - +12%<br />-4.10ms -
+									<strong>unsure ❔</strong><br />-10% - +12%<br />-4.10ms -
 									+5.24ms
 								</td>
 								<td align="center">-</td>

diff --git a/tests/fixtures/test-results-existing-running.html b/tests/fixtures/test-results-existing-running.html
@@ -18,9 +18,9 @@ <h3>Summary</h3>
 								href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 								title="Currently running in Pull Request Test #50…"
 								aria-label="Currently running in Pull Request Test #50…"
-								>⏱
+								>⏳
 							</a></span
-						>report-id: <strong>unsure 🔍</strong>
+						>report-id: <strong>unsure ❔</strong>
 						<em>-10% - +12% (-4.10ms - +5.24ms)</em><br /><sup
 							>local-framework vs base-framework</sup
 						>
@@ -44,7 +44,7 @@ <h3>Results</h3>
 							href="https://github.com/andrewiggins/tachometer-reporter-action/runs/862215228"
 							title="Currently running in Pull Request Test #50…"
 							aria-label="Currently running in Pull Request Test #50…"
-							>⏱
+							>⏳
 						</a></span
 					><strong>report-id</strong></summary
 				>
@@ -93,7 +93,7 @@ <h3>Results</h3>
 								</td>
 								<td align="center">-</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-12% - +9%<br />-5.24ms -
+									<strong>unsure ❔</strong><br />-12% - +9%<br />-5.24ms -
 									+4.10ms
 								</td>
 							</tr>
@@ -104,7 +104,7 @@ <h3>Results</h3>
 									<strong>slower ❌</strong><br />9% - 38%<br />3.55ms - 12.77ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-10% - +12%<br />-4.10ms -
+									<strong>unsure ❔</strong><br />-10% - +12%<br />-4.10ms -
 									+5.24ms
 								</td>
 								<td align="center">-</td>

diff --git a/tests/fixtures/test-results-new-comment.html b/tests/fixtures/test-results-new-comment.html
@@ -13,7 +13,7 @@ <h3>Summary</h3>
 						class="summary::JQx4P-VUyiFWEMlMIUU5w9uyy6s"
 						data-run-number="50"
 					>
-						<span class="status"></span>test_bench: <strong>unsure 🔍</strong>
+						<span class="status"></span>test_bench: <strong>unsure ❔</strong>
 						<em>-10% - +12% (-4.10ms - +5.24ms)</em><br /><sup
 							>local-framework vs base-framework</sup
 						>
@@ -79,7 +79,7 @@ <h3>Results</h3>
 								</td>
 								<td align="center">-</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-12% - +9%<br />-5.24ms -
+									<strong>unsure ❔</strong><br />-12% - +9%<br />-5.24ms -
 									+4.10ms
 								</td>
 							</tr>
@@ -90,7 +90,7 @@ <h3>Results</h3>
 									<strong>slower ❌</strong><br />9% - 38%<br />3.55ms - 12.77ms
 								</td>
 								<td align="center">
-									<strong>unsure 🔍</strong><br />-10% - +12%<br />-4.10ms -
+									<strong>unsure ❔</strong><br />-10% - +12%<br />-4.10ms -
 									+5.24ms
 								</td>
 								<td align="center">-</td>

diff --git a/tests/fixtures/test-results-summary.html b/tests/fixtures/test-results-summary.html
@@ -3,7 +3,7 @@
 	class="summary::JQx4P-VUyiFWEMlMIUU5w9uyy6s"
 	data-run-number="50"
 >
-	<span class="status"></span>test_bench: <strong>unsure 🔍</strong>
+	<span class="status"></span>test_bench: <strong>unsure ❔</strong>
 	<em>-10% - +12% (-4.10ms - +5.24ms)</em><br /><sup
 		>local-framework vs base-framework</sup
 	>