Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle measurement names #25

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Properly handle measurement names #25

merged 1 commit into from
Sep 15, 2020

Conversation

andrewiggins
Copy link
Owner

@andrewiggins andrewiggins commented Sep 14, 2020

Reported in lit-html/pull#1251

@github-actions
Copy link

github-actions bot commented Sep 14, 2020

📊 Tachometer Benchmark Results

Summary

  • test_bench: unsure 🔍 -10% - +12% (-4.10ms - +5.24ms)
    local-framework vs base-framework
  • test_bench_2: slower ❌ 8% - 35% (3.22ms - 11.96ms)
    base-framework vs other-framework Customize summary

Results

test_bench
VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework32.09ms - 38.19ms-faster ✔
8% - 27%
3.22ms - 11.96ms
faster ✔
9% - 28%
3.55ms - 12.77ms
base-framework39.60ms - 45.87msslower ❌
8% - 35%
3.22ms - 11.96ms
-unsure 🔍
-12% - +9%
-5.24ms - +4.10ms
local-framework39.84ms - 46.76msslower ❌
9% - 38%
3.55ms - 12.77ms
unsure 🔍
-10% - +12%
-4.10ms - +5.24ms
-
test_bench_2
VersionAvg timevs other-frameworkvs base-frameworkvs local-frameworkvs fast-framework
other-framework43.30ms - 52.48ms-slower ❌
19% - 54%
7.24ms - 18.26ms
unsure 🔍
-1% - +26%
-0.40ms - +10.72ms
unsure 🔍
-3% - +24%
-1.15ms - +10.34ms
base-framework39.60ms - 45.87msslower ❌
8% - 35%
3.22ms - 11.96ms
-unsure 🔍
-22% - -0%
-10.72ms - +0.40ms
unsure 🔍
-12% - +9%
-5.24ms - +4.10ms
local-framework39.84ms - 46.76msslower ❌
9% - 38%
3.55ms - 12.77ms
unsure 🔍
-21% - +2%
-10.34ms - +1.15ms
-unsure 🔍
-10% - +12%
-4.10ms - +5.24ms
fast-framework32.09ms - 38.19msfaster ✔
17% - 36%
7.24ms - 18.26ms
faster ✔
8% - 27%
3.22ms - 11.96ms
faster ✔
9% - 28%
3.55ms - 12.77ms
-

tachometer-reporter-action v2 for PR Multi Init Flow

@github-actions
Copy link

github-actions bot commented Sep 14, 2020

📊 Tachometer Benchmark Results

Summary

  • test-bench-1: unsure 🔍 -10% - +12% (-4.10ms - +5.24ms)
    local-framework vs base-framework
  • test-bench-2: slower ❌ 8% - 35% (3.22ms - 11.96ms)
    base-framework vs other-framework Customize summary

Results

test-bench-1
VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework32.09ms - 38.19ms-faster ✔
8% - 27%
3.22ms - 11.96ms
faster ✔
9% - 28%
3.55ms - 12.77ms
base-framework39.60ms - 45.87msslower ❌
8% - 35%
3.22ms - 11.96ms
-unsure 🔍
-12% - +9%
-5.24ms - +4.10ms
local-framework39.84ms - 46.76msslower ❌
9% - 38%
3.55ms - 12.77ms
unsure 🔍
-10% - +12%
-4.10ms - +5.24ms
-
test-bench-2
VersionAvg timevs other-frameworkvs base-frameworkvs local-frameworkvs fast-framework
other-framework43.30ms - 52.48ms-slower ❌
19% - 54%
7.24ms - 18.26ms
unsure 🔍
-1% - +26%
-0.40ms - +10.72ms
unsure 🔍
-3% - +24%
-1.15ms - +10.34ms
base-framework39.60ms - 45.87msslower ❌
8% - 35%
3.22ms - 11.96ms
-unsure 🔍
-22% - -0%
-10.72ms - +0.40ms
unsure 🔍
-12% - +9%
-5.24ms - +4.10ms
local-framework39.84ms - 46.76msslower ❌
9% - 38%
3.55ms - 12.77ms
unsure 🔍
-21% - +2%
-10.34ms - +1.15ms
-unsure 🔍
-10% - +12%
-4.10ms - +5.24ms
fast-framework32.09ms - 38.19msfaster ✔
17% - 36%
7.24ms - 18.26ms
faster ✔
8% - 27%
3.22ms - 11.96ms
faster ✔
9% - 28%
3.55ms - 12.77ms
-

tachometer-reporter-action v2 for PR Setup Job Flow

@github-actions
Copy link

github-actions bot commented Sep 14, 2020

📊 Tachometer Benchmark Results

Summary

duration

  • multi-bench-1: faster ✔ 4% - 8% (6.30ms - 13.34ms)
    local-framework vs base-framework
  • multi-bench-2: slower ❌ 9% - 17% (0.32ms - 0.59ms)
    base-framework vs fast-framework Customize summary

window.usedJSHeapSize

  • multi-bench-1: slower ❌ 91% - 91% (3.25ms - 3.26ms)
    local-framework vs base-framework
  • multi-bench-2: faster ✔ 8% - 8% (0.09ms - 0.09ms)
    base-framework vs fast-framework Customize summary

Results

multi-bench-1

duration

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework137.71ms - 141.73ms-faster ✔
20% - 22%
34.69ms - 39.26ms
faster ✔
14% - 18%
23.26ms - 31.06ms
base-framework175.60ms - 177.79msslower ❌
24% - 28%
34.69ms - 39.26ms
-slower ❌
4% - 8%
6.30ms - 13.34ms
local-framework163.53ms - 170.22msslower ❌
16% - 22%
23.26ms - 31.06ms
faster ✔
4% - 8%
6.30ms - 13.34ms
-

window.usedJSHeapSize

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework2.61ms - 2.61ms-faster ✔
27% - 27%
0.95ms - 0.95ms
faster ✔
62% - 62%
4.20ms - 4.21ms
base-framework3.56ms - 3.57msslower ❌
36% - 37%
0.95ms - 0.95ms
-faster ✔
48% - 48%
3.25ms - 3.26ms
local-framework6.81ms - 6.82msslower ❌
161% - 161%
4.20ms - 4.21ms
slower ❌
91% - 91%
3.25ms - 3.26ms
-
multi-bench-2

duration

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework3.46ms - 3.70ms-faster ✔
8% - 15%
0.32ms - 0.59ms
slower ❌
34% - 54%
0.89ms - 1.28ms
base-framework3.98ms - 4.10msslower ❌
9% - 17%
0.32ms - 0.59ms
-slower ❌
52% - 72%
1.38ms - 1.71ms
local-framework2.34ms - 2.65msfaster ✔
26% - 35%
0.89ms - 1.28ms
faster ✔
34% - 42%
1.38ms - 1.71ms
-

window.usedJSHeapSize

VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework1.09ms - 1.09ms-slower ❌
9% - 9%
0.09ms - 0.09ms
slower ❌
11% - 11%
0.11ms - 0.11ms
base-framework1.00ms - 1.00msfaster ✔
8% - 8%
0.09ms - 0.09ms
-slower ❌
2% - 2%
0.02ms - 0.02ms
local-framework0.98ms - 0.98msfaster ✔
10% - 10%
0.11ms - 0.11ms
faster ✔
2% - 2%
0.02ms - 0.02ms
-

tachometer-reporter-action v2 for PR Multi-Measurement Setup Job Flow

@github-actions
Copy link

github-actions bot commented Sep 14, 2020

📊 Tachometer Benchmark Results

Summary

  • test_bench: unsure 🔍 -10% - +12% (-4.10ms - +5.24ms)
    local-framework vs base-framework

Results

test_bench
VersionAvg timevs fast-frameworkvs base-frameworkvs local-framework
fast-framework32.09ms - 38.19ms-faster ✔
8% - 27%
3.22ms - 11.96ms
faster ✔
9% - 28%
3.55ms - 12.77ms
base-framework39.60ms - 45.87msslower ❌
8% - 35%
3.22ms - 11.96ms
-unsure 🔍
-12% - +9%
-5.24ms - +4.10ms
local-framework39.84ms - 46.76msslower ❌
9% - 38%
3.55ms - 12.77ms
unsure 🔍
-10% - +12%
-4.10ms - +5.24ms
-

tachometer-reporter-action v2 for PR Single Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant