Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to include data/ files? #1

Closed
tseemann opened this issue Apr 5, 2018 · 1 comment
Closed

Default to include data/ files? #1

tseemann opened this issue Apr 5, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@tseemann
Copy link
Contributor

tseemann commented Apr 5, 2018

I note that data/ has the files downloaded.
It would be great if it could default to use those.
Are they part of the pip resources section?

eg.

parser.add_argument('--output_prefix',	 '-o', help='Output directory', 
   default =   pkg_resources.get_distribution("plasmidpredictor").the_files_we_need)

I guess the reason is ethical/political

Could make everyone cite Plasmidfinder as well as your future JOSS paper.

@andrewjpage
Copy link
Owner

I've bundled the database and included it by default if you dont provide a database. I've also added the plasmidfinder paper citation to the readme and updated the location to point to their bitbucket version instead of the old zip.

@andrewjpage andrewjpage added the enhancement New feature or request label Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants