Buffers shouldn't have default vals

andrewjstone · Sep 1, 2011 · 9ab40a6 · 9ab40a6
1 parent 43ae07b
commit 9ab40a6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/lib/schema/buffer.js b/lib/schema/buffer.js
@@ -19,20 +19,6 @@ var SchemaType = require('../schematype')
 
 function SchemaBuffer (key, options) {
   SchemaType.call(this, key, options);
-
-  var self = this
-    , defaultBuf
-    , fn;
-
-  if (this.defaultValue) {
-    defaultBuf = this.defaultValue;
-    fn = 'function' == typeof defaultBuf;
-  }
-
-  this.default(function(){
-    var buf = fn ? defaultBuf() : defaultBuf || null;
-    return new MongooseBuffer(buf, [self.path, this]);
-  });
 };
 
 /**

diff --git a/test/types.buffer.test.js b/test/types.buffer.test.js
@@ -13,7 +13,7 @@ var start = require('./common')
 // can't index Buffer fields yet
 
 function valid (v) {
-  return v.length > 10;
+  return !v || v.length > 10;
 }
 
 var subBuf = new Schema({
@@ -75,7 +75,7 @@ module.exports = {
         t.sub.push({ name: 'Friday Friday' });
         t.save(function (err) {
           err.message.should.eql('Validation failed');
-          err.errors.buf.type.should.equal('valid failed');
+          err.errors.buf.type.should.equal('required');
           t.sub[0].buf = new Buffer("well well");
           t.save(function (err) {
             err.message.should.eql('Validation failed');