gvm available - Refresh source repo and always report binary versions #39
Labels
Comments
andrewkroh
added a commit
that referenced
this issue
Nov 4, 2021
This improves the `gvm available` command to ensure the data returned is as accurate as possible. It addresses a few different issues. The command uses the a cached copy of the Go git repo to list the available version tags. This will now refresh the source repo if the cache is not from the current day. The tags from the source repo were the only ones that were listed in the output. Each of those versions were then annotated with whether a binary version is available. So if the source repo was stale you would never newly released binary versions. This changes the output to merge the list of source repo tags and binary releases so that you generally always see the latest data. Fixes #39
Merged
andrewkroh
added a commit
that referenced
this issue
Nov 4, 2021
This improves the `gvm available` command to ensure the data returned is as accurate as possible. It addresses a few different issues. The command uses the a cached copy of the Go git repo to list the available version tags. This will now refresh the source repo if the cache is not from the current day. The tags from the source repo were the only ones that were listed in the output. Each of those versions were then annotated with whether a binary version is available. So if the source repo was stale you would never newly released binary versions. This changes the output to merge the list of source repo tags and binary releases so that you generally always see the latest data. Fixes #39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like
gvm availabledoes not refresh the git repo when source is present. So there are two code paths:When source code is present in
~/.gvm/cache/goit reads the git tags and then checks if each tag has an available binary by querying the Go download metadata.The other path is when no source is present and it straight returns the Go download metadata.
So there is room for improvement here in the case of source code being present. It should do a better job at merging the results of the Go repo git tags and the available binary versions from the Go website. And it should automatically refresh the git repo if it's more than a day old (that's how other code paths behave that use the source repo).
Relates #38 (comment)
The text was updated successfully, but these errors were encountered: