Update bundle-audit prior to run #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--update` isn't a valid option to pass, run `update` and then `check` separately
Hidden in https://github.com/rubysec/bundler-audit/blob/master/lib/bundler/audit/database.rb#L101-L119 bundler-audit is shelling out to use `git` binary. If it doesn't exist then we get the error message "Skipping update" logged from `bundle-audit update`. Install git inside the docker image so bundler audit can grab the latest advisory database for us.
Add git so bundle audit clones the advisory repo
|
@andrewmcodes is there anything we can do to help you get this merged? Updating the database is obviously very important to auditing. 😄 Thanks for fixing this @jfi. |
|
@bbugh My apologies - this project totally fell off my radar! Feel free to ping me elsewhere on the web bc my GitHub notifications are a bit of a dumpster fire. I will get this rolled out for y'all. |
andrewmcodes
approved these changes
Jul 12, 2020
|
@jfi just to let you know, this was released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Description
There are two fixes here:
bundle audit update, defined in the documentation (as opposed tobundle audit check --update, previously used)bundle audit updatecan runFurther information:
Hidden in https://github.com/rubysec/bundler-audit/blob/master/lib/bundler/audit/database.rb#L101-L119 bundler-audit is shelling out to use git binary. If it doesn't exist then we get the error message "Skipping update" logged from bundle-audit update.
Install git inside the docker image so bundler audit can grab the latest advisory database for us.
Fixes # (issue)
Why should this be added
I couldn't make this action run as it always failed on an outdated rails-html-sanitizer vulnerability, that was removed when I ran
bundle audit update.Checklist