Add dark mode #136
Merged
Add dark mode #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billykern
commented
Mar 14, 2024
| const typingIndicatorStyle = { | ||
| backgroundColor: theme.palette.background.paper, | ||
| color: theme.palette.text.primary, | ||
| }; |
There was a problem hiding this comment.
Not sure if there is a better way to apply the MUI themes, this was the best I could come up with, but let me know if you have another idea
billykern
commented
Mar 14, 2024
| @@ -67,6 +67,7 @@ | |||
| "eslint-plugin-react": "^7.33.2", | |||
| "eslint-plugin-react-hooks": "^4.6.0", | |||
| "html-webpack-plugin": "^5.5.3", | |||
| "jest-environment-jsdom": "^29.7.0", | |||
There was a problem hiding this comment.
apparently this became necessary with jest v28, I had to do this to get around TypeError: Cannot read properties of undefined (reading 'html')
|
Looks great! Thanks @billykern! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #129
Please let me know if you would prefer to adjust the color scheme or toggle position...
New dark theme:
Regression light theme:
New Option:
