Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date.create fails to parse Russian date strings #524

Closed
smurali31 opened this issue Nov 24, 2015 · 13 comments
Closed

Date.create fails to parse Russian date strings #524

smurali31 opened this issue Nov 24, 2015 · 13 comments
Milestone

Comments

@smurali31
Copy link

Windows Long Date format displays Russian strings as follows:
3 октября 2014 r.
Sugarjs however fails to parse this string

Same goes for "2015년 11월 24일 화요일" in Korean.

@andrewplummer
Copy link
Owner

Well I'm curious... for Russian what you posted was a Latin "r", but the Russian is a different letter entirely so that can't be right... I copy/pasted your example and was scratching my head before I figured it out. In any case I added handling of these formats.

@andrewplummer andrewplummer added this to the 2.0.0 milestone Nov 25, 2015
@smurali31
Copy link
Author

Excellent. Thanks, Andrew. What I copy pasted was the string that you can find in Windows Region and language settings by changing your region to Russian. You can also get the same string by doing the following with C#

CultureInfo ci = new CultureInfo("ru-RU");
Thread.CurrentThread.CurrentCulture = ci;
Console.WriteLine(DateTime.Now.ToLongDateString());

Btw, when is this expected to release?

@andrewplummer
Copy link
Owner

hahah... I'm not saying you're wrong, but if that were true it would be an epic bug (I get the right character in XP/7... don't really have access to C#).

Expected release is very soon! And please don't go around looking at the timestamps of my comments on other issues because this time I really mean it!

@smurali31
Copy link
Author

seems like 1.5.0 has the fix too. Can you please confirm?

@andrewplummer
Copy link
Owner

Sorry, the next version of 1 was going to be 1.4.2 but will now be 1.5, (I changed the label name, but it didn't update inline it seems). Yes, this fix will be included.

@smurali31
Copy link
Author

Excellent! Thanks

@smurali31
Copy link
Author

Is 1.5 a stable version? http://sugarjs.com still points to 1.4.1

@andrewplummer
Copy link
Owner

It's not released yet. Will be release with the same timing as 2.0.0 -- a few backward compatible changes and bugfixes like this one.

@smurali31
Copy link
Author

Just wondering where we are w.r.to 1.5 release? You mentioned "very soon" :-)

@andrewplummer
Copy link
Owner

Hello, yes things are snowballing together and delays keep happening, however I'm still doing everything I can to try to live up to "very soon". Sorry can't really be more specific than that but will do my best!

@muralidhars
Copy link

Hey Andrew - How is the release looking? Sorry to be persistent..

@andrewplummer
Copy link
Owner

So I really wanted to get everything together this weekend but a lot of small flames left to stomp out. However this is mostly around the site/documentation. Meanwhile the tests are passing across the board and I've pushed the latest build... let's call it RC-1. Maybe you'd like to be first to try it out?

https://github.com/andrewplummer/Sugar/blob/master-2.0.0/sugar.js
https://github.com/andrewplummer/Sugar/blob/master-2.0.0/sugar.min.js

@vendethiel
Copy link

👍 (can't test it right now: will try to find time wednesday)

andrewplummer added a commit that referenced this issue Jul 24, 2016
andrewplummer added a commit that referenced this issue Jul 24, 2016
andrewplummer added a commit that referenced this issue Jul 24, 2016
Former-commit-id: 3d31b3c606da5f291f7e937e40ffcd1f55ffce49 [formerly fb4fc543aad6946ca6b42eea1ec0e8293740b7c1]
Former-commit-id: 0187caf614089525c5a47450118f5010620cdec0
andrewplummer added a commit that referenced this issue Jul 24, 2016
Former-commit-id: c69fa11
Former-commit-id: c40bce35a92ad88149f8a5ab1a181e2fc477b5b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants