Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Update rimraf to 2.5.3 #23

Open
rosskukulinski opened this issue Jul 5, 2016 · 6 comments
Open

[Security] Update rimraf to 2.5.3 #23

rosskukulinski opened this issue Jul 5, 2016 · 6 comments

Comments

@rosskukulinski
Copy link

minimatch <=3.0.1 is vulnerable to a Regex Denial of Service attack
https://nodesecurity.io/advisories/118

node-mv depends on rimraf which depends on glob which depends on minimatch which has the vulnerability.

Please bump rimraf from ~2.4.0 to >=2.5.3 to resolve this vulnerability

isaacs/minimatch@6944abf
isaacs/node-glob@f0f0872
isaacs/rimraf@9e2c310

@otramony
Copy link

Hello @andrewrk / @cscott / @deestan / @mcandre. Any way we can get this update? Preferably to a more recent version of rimraf. In our case, minimatch fixed our vulnerability in v3.0.5 and rimraf v2.7.1 has the necessary updates for us to pick up the fix, which will also resolve the request from @rosskukulinski.

@mcandre
Copy link
Contributor

mcandre commented Aug 16, 2022

Please submit a tested security patch.

Another option involves publishing a patched fork of this dependency package, and then publishing a patched downstream package. Had to do that many times for Node projects lacking proactive maintainers.

@ljharb
Copy link

ljharb commented Aug 16, 2022

Another option is to just ignore this warning, since it's not actually a vulnerability.

Being able to DOS yourself by providing commands to this package is not an attack.

@mcandre
Copy link
Contributor

mcandre commented Aug 16, 2022

Disregard that. Not a good posture.

@ljharb
Copy link

ljharb commented Aug 16, 2022

@mcandre it's a quite good posture, actually. Most CVEs in the npm ecosystem are false positives, and since I'm responsible for well over 10% of npm's entire download traffic, my security postures are more thoroughly battle-tested than most, including this one.

@otramony
Copy link

otramony commented Aug 16, 2022

Thank you all for the fast response. This is the minimatch issue I was looking at, which in turn was fixed by their brace-expansion dependency:
https://security.snyk.io/vuln/npm:brace-expansion:20170302
isaacs/minimatch@a8763f4

I'm also leaning on this being a warning and not necessarily a vulnerability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants