andrewrk
Follow
Pinned
2,708 contributions in the last year
Contribution activity
March 2023
Created 186 commits in 4 repositories
Created a pull request in ziglang/zig that received 12 comments
eliminate posix_spawnp from the standard library
Today I found out that posix_spawnp is trash. It's actually implemented on top of posix_spawn inside of libc (or libSystem in the case of macOS). S…
+3
−422
•
12
comments
Opened 10 other pull requests in 1 repository
ziglang/zig
10
merged
- std.Build.RunStep: fix control flow with qemu+glibc logic
- fix std.Build.OptionsStep
- CI: more aggressively check zig1 bootstrapping
-
@trapfixups - std.Build.addModule: return the created module
- link: give executable bit to wasm executables sometimes
- std.process.Child: remove pid and handle, add id
- add doc comments to std.fs.File.default_mode
- std: add fchmodat
- packages: avoid creating multiple modules with same build.zig
Reviewed 10 pull requests in 1 repository
ziglang/zig
10 pull requests
-
tests: add
-Dskip-cross-glibcoption - llvm: store undef if safety is disabled
- main: add debug option to dump unoptimized llvm ir
- retry cache file creation
- std.fmt: add bytesToHex() to encode bytes as hex digits
- wasm-linker: emit build_id section
-
@trapfixups -
add
@trapbuiltin - crypto.25519.field: conditionally de-inline mul
- Std.io.poll
Created an issue in ziglang/zig that received 15 comments
f16 regressions in the LLVM16 branch on macOS
On my x86_64-macos laptop, I can reproduce the issue this way: const std = @import("std"); pub fn main() !void { foo(4.0); } fn foo(y: f16) void { std
15
comments
Opened 44 other issues in 2 repositories
ziglang/zig
38
open
5
closed
- inter-process race condition when writing builtin.zig file
- communicate the error when a test fails in release mode
- take away EmitOption.emit_to option and make it give a FileSource
- rename --verbose to --verbose-spawn and limit the scope of what it does
- eliminate std.Build.CheckObjectStep.runAndCompare
- unit tests that write files to cwd have racy failures
- eliminate warnings from the linker
- instead of embedding the compiler in the check-cases process, spawn the compiler as a sub-process and communicate the updates using the compiler protocol
- add a skip reason to show up in the build runner summary
- port uuid link test over to the new build system API
- static libraries can be picked up instead of system libraries when -l is used
- ld.lld: warning: Linking two modules of different target triples ... arm-unknown-linux-musleabihf vs armv6kz-unknown-linux-musleabihf
- collect error return traces from errors other than error.MakeFailed
- add addCheckFile method to FileSource
- make the cwd of RunStep take a Cache.Directory
- add .h file generation tests back
- add Darwin support for detecting maxrss of child process
- add Windows support for detecting maxrss of child process
- support G, M, GiB, MiB, GB, MB, etc. shorthands in --maxrss arg
- extract struct fields from std.Build which should go into a struct shared by all Build instances
- build runner: actually limit the peak RSS rather than enforcing it post-hoc
- miscompilation regarding pointer to optional slice
- remove CompileStep.output_dir from the build system API
- remove std.log usage from std.Build.Cache in favor of proper error reporting
- RunStep: learn target information from the binary on disk rather than knowledge of the target ahead of time
- Some issues not shown.