Add shim for deprecated/removed ElementTree.getiterator(tag) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.
Instead of bumping up the Python version requirement for Typecatcher to work I made a shim which calls the good old
ElementTree.getiterator(tag)for Python 3.1 and below, and instead use the newElementTree.iter(tag)for newer versions of Python (introduced since 3.2). The former method has been removed starting from Python 3.9.I can't build through
setup.pydue to issues with my build environment (unable to importDistUtilsExtra.autodespite havingpython3-aptinstalled on Ubuntu 21.04). However, I've tested it with bothtests/test_pyflake.pyandtests/unit_tests.pyand finally run the program throughpython3 bin/typecatcher.