Merge pull request #35 from andrewthetechie/schedule-blank-string

Exclude none values when creating and updating
andrewthetechie · Jan 8, 2022 · 818dd54 · 818dd54
2 parents 67cbd29 + 376578a
commit 818dd54
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/healthchecks_io/client/async_client.py b/src/healthchecks_io/client/async_client.py
@@ -98,7 +98,7 @@ async def create_check(self, new_check: CheckCreate) -> Check:
         """
         request_url = self._get_api_request_url("checks/")
         response = self.check_response(
-            await self._client.post(request_url, json=new_check.dict())
+            await self._client.post(request_url, json=new_check.dict(exclude_none=True))
         )
         return Check.from_api_result(response.json())
 
@@ -118,7 +118,8 @@ async def update_check(self, uuid: str, update_check: CheckCreate) -> Check:
         request_url = self._get_api_request_url(f"checks/{uuid}")
         response = self.check_response(
             await self._client.post(
-                request_url, json=update_check.dict(exclude_unset=True)
+                request_url,
+                json=update_check.dict(exclude_unset=True, exclude_none=True),
             )
         )
         return Check.from_api_result(response.json())

diff --git a/src/healthchecks_io/client/sync_client.py b/src/healthchecks_io/client/sync_client.py
@@ -138,7 +138,7 @@ def create_check(self, new_check: CheckCreate) -> Check:
         """
         request_url = self._get_api_request_url("checks/")
         response = self.check_response(
-            self._client.post(request_url, json=new_check.dict())
+            self._client.post(request_url, json=new_check.dict(exclude_none=True))
         )
         return Check.from_api_result(response.json())
 
@@ -163,7 +163,10 @@ def update_check(self, uuid: str, update_check: CheckCreate) -> Check:
         """
         request_url = self._get_api_request_url(f"checks/{uuid}")
         response = self.check_response(
-            self._client.post(request_url, json=update_check.dict(exclude_unset=True))
+            self._client.post(
+                request_url,
+                json=update_check.dict(exclude_unset=True, exclude_none=True),
+            )
         )
         return Check.from_api_result(response.json())