Skip to content

Commit

Permalink
test-genrandom: ensure stdout is set to _O_BINARY on Windows
Browse files Browse the repository at this point in the history
Commit a6ca8c6 (Set _O_BINARY as default fmode for both MinGW and MSVC)
removed the definition of _CRT_fmode from mingw.c. Before this commit,
since test-genrandom is linked against libgit.a, the MinGW process
initialization code would pick up that definition of _CRT_fmode, which was
initialized to _O_BINARY. After this commit, however, text mode is used
for std(in|out|err) because it is the default in absence of _CRT_fmode.
In order to fix that, we must use git-compat-util.h, which overrides
main() to set the mode to binary.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
j6t authored and gitster committed Sep 21, 2009
1 parent 0984e3a commit a16753d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions test-genrandom.c
Expand Up @@ -4,8 +4,7 @@
* Copyright (C) 2007 by Nicolas Pitre, licensed under the GPL version 2.
*/

#include <stdio.h>
#include <stdlib.h>
#include "git-compat-util.h"

int main(int argc, char *argv[])
{
Expand Down

0 comments on commit a16753d

Please sign in to comment.