-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add property to disable related videos #28
Conversation
@franciscorode, Thanks for the PR. You can pass Note: that you can't disable related videos referring to the docs.
|
I don't think it's a good idea to introduce a separate prop for every parameter, since it will make component really large. Moreover you can pass any of them via
|
I understand your position, it's fine although I don't like the idea of passing options in the URL. I tried to pass the option in prop |
@franciscorode, We can add |
Yes seem a good idea, I understand these points, tell me if you don't agree with some of them
|
@franciscorode, awesome! |
Good! I can work on this, give me a few days and create another pull request, close this |
@franciscorode, Thank you so much. I will be glad to review your PR. |
First, congrats by the repo!
I tried to disable related videos by adding
rel
option inplayerOptions
withplayerVars
but for some reason, it didn't work, the only way to make it work was to add it as a GET parameter in thesrc
prop. To not set options in several sites I think is better to add it as a prop and I have added the changes to do it