Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback Memory Leak #12

Closed
andrewvy opened this issue Oct 1, 2017 · 0 comments
Closed

Callback Memory Leak #12

andrewvy opened this issue Oct 1, 2017 · 0 comments
Assignees
@andrewvy
Labels
bug
Milestone
v1.0.0

Comments

@andrewvy
Copy link
Owner

andrewvy commented Oct 1, 2017

https://github.com/andrewvy/chrome-remote-interface/blob/master/lib/page_session.ex#L180

This doesn't remove the callback when a message is received for a callback. This leaves resolved callbacks in the state, when we should actually remove it!
@andrewvy andrewvy added the bug label Oct 1, 2017
@andrewvy andrewvy added this to the v1.0.0 milestone Oct 1, 2017
@andrewvy andrewvy self-assigned this Oct 1, 2017
andrewvy added a commit that referenced this issue Oct 1, 2017
@andrewvy
🐛 Remove callbacks when finished
31767c2 
#12
@andrewvy andrewvy closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvy andrewvy

Labels
bug
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@andrewvy