Initialize io #49
Initialize io #49
Conversation
|
I don't really understand the need for this change, but then I've only ever used FoX from one process and done all of the XML IO there. Is opening a scratch file on all nodes a performance problem compared to multiple processes reading XML documents? Could you also rebase this branch on master - so it doesn't have the colons patch or gfortran stop message included? |
|
system admistrators started to complain because the program was opening thousands of scratch files :). |
Initializing the IO error codes each time that a xml file in open for reading may become cumbersome in parallel application with many processes opening scratch file for tests. In this case it is preferable to run setup_io just with one node and propagate the results to all other nodes. I have redefined setup_io as an interface which refers to 2 module procedures. setup_io_scracth which is the former setup_io routine and a setup_io_with_data where err_code eor_code and eof_code are provided as arguments with which io_err, io_eor and io_eof are initialized. I have added a private logical variable io_init that is toggled to true by setup_io on exit. setup_io checks the io_init variable when starting and in true returns without no further actions.
pietrodelugas
force-pushed
the
initialize_io
branch
from
e2ee1a3
to
d9d8371
Compare
|
the branch has been rebased to testing |
|
could you point this at my master branch, not testing (which was me setting up the continuous integration - my aim isn't to test new features there although the name is rather ambiguous). |
|
sorry Andrew. I was sure to have redirected the pull request to the master branch long time ago. |
The current setup_io opened a scratch file whenever a file was opened for reading. This may become cumbersome when the library is used in parallel MPI programs and has to read more then one file.
I have added a flag in setup_io that is toggled to true as soon as setup_io initializes io_err, io_eor and io_eof, and on successive calls of setup_io the routine returns without performing any more test.
I have also added the possibility to initialize the error codes by providing their values as arguments to setup_io. This can be useful in parallel application with one node that performs the test on the scratch file and then broadcasts the result to other nodes which will setup the error codes using the interface with the 3 err codes in input.