Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for modules argument for Babel #57

Closed
wants to merge 0 commits into from

Conversation

jaheba
Copy link
Contributor

@jaheba jaheba commented Sep 9, 2015

Allows to pass a modules argument to babel.

See: https://babeljs.io/docs/usage/modules/

@andreyfedoseev
Copy link
Owner

@jaheba Thank you for the pull request. However, I can't accept it since it contains the unnecessary changes in setup.py. Also, please include this new paramter to the documentation for BabelCompiler in README.rst.

@jaheba
Copy link
Contributor Author

jaheba commented Sep 22, 2015

Argh, this auto add new changes to pull request feature...

However I think it would be a good idea to at least add watchdog as an extra . One then can install django-static-precompiler with watchdog support as follows:

$ pip install django-static-precompiler[watch]

If you agree I would add this features and add them to this pull request together with some documentation.

@andreyfedoseev
Copy link
Owner

Argh, this auto add new changes to pull request feature...

You can create a new branch and cherry pick the selected changes there to isolate them, and then submit a pull request from this branch.

However I think it would be a good idea to at least add watchdog as an extra .

I like that! Would submit it as a separate pull request?

If you agree I would add this features and add them to this pull request together with some documentation.

I do agree, and feel free to add yourself to AUTHORS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants