Add support of nginx X-Accel-Redirect header

andreymal · Mar 31, 2019 · d38ead1 · d38ead1
1 parent 1765fcf
commit d38ead1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/mini_fiction/settings.py b/mini_fiction/settings.py
@@ -287,6 +287,8 @@ class Config(object):
 
     STORY_DOWNLOAD_SLUGIFY_FILENAMES = False
 
+    ACCEL_REDIRECT_HEADER = None  # set 'X-Accel-Redirect' if you use nginx
+
     CONTACTS = [
         {
             'name': 'website',

diff --git a/mini_fiction/views/story.py b/mini_fiction/views/story.py
@@ -619,11 +619,15 @@ def download(story_id, filename):
 
     # TODO: delete file if story was deleted
     if not debug:
-        # FIXME: fix security before sending static file with nginx
-        # TODO: for example, /media/stories/{md5(updated + secret_random_story_key)}/filename.zip
-        # return redirect(path to media)
-        response = send_file(storage_path)
-        response.headers['Content-Type'] = fmt.content_type
+        if current_app.config.get('ACCEL_REDIRECT_HEADER'):
+            response = Response(b'', content_type=fmt.content_type)
+            response.headers[current_app.config['ACCEL_REDIRECT_HEADER']] = url_for(
+                'media', filename='stories/{}/{}'.format(story.id, full_filename)
+            )
+        else:
+            response = send_file(storage_path)
+            response.headers['Content-Type'] = fmt.content_type
+
         response.headers['Content-Disposition'] = 'attachment'
 
     else: