Added trigger filtering capabilities to the location node for specific events #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that the entire member list was being sent in 2 cases: 1. when any member's location name had changed or when no members' location had changed... Although I think there's more to it and I suspect it has to do with different circles and places and there being only 1 "updated_locations" array...
The same location can have a life360 place with a different name in a different circle. E.g. circles made by different users that invite one another. The way it was written, overlapping places cause spurious location events.
Files checked in: nodes/*
… that is planned. Files checked in: index.js nodes/location.* nodes/server.js
I have only tested the any circle, any event case. Also, this currently does not support multiple location nodes. Files checked in: nodes/location.js nodes/server.js
Changed the changed value callback to an array to support multiple location nodes. Fixed a problem with the calculation of a location's previous occupancy. Added some debug statements. Files checked in: nodes/location.js nodes/server.js
…-life into first_arrive_leave_trigger
…t72/node-red-contrib-life into first_arrive_leave_trigger
Files checked in: nodes/location.html nodes/location.js nodes/server.js
Files checked in: index.js nodes/location.html nodes/location.js nodes/server.js
Files checked in: nodes/server.js
…ing last to leave. Files checked in: nodes/server.js
…eave events on startup. Files checked in: nodes/location.html nodes/location.js nodes/server.js
Files checked in: package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the bug fixes from my previous PR.
The original behavior is maintained (select any circle, any person, any place, and any event - which are the defaults - to get the same behavior, aside from the bug fixes in the previous PR), and the node output is still the member json structure, so these changes are backward compatible with previous versions.
I will push out a major version bump commit shortly (which I just realized I hadn't done).
Since I haven't gotten a response about my first PR, I will start looking into releasing my fork as an independent node. If you merge this PR or indicate a willingness to take a look at these changes, I'll abandon the effort to publish my fork as a separate package.
Thanks so much for your code and releasing it under GPL 3.0.