Add configurable transition for HK cmd and resolve issues with help blocks. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things I did in this PR.
First was allowing user to set (change) transition value being sent to z2m for homekit commands.
Previously it was hardcoded
transition: 0which in my case was causing a lot of issues on z2m side (No converter available for 'transition' (0) zigbee2mqtt)Not it is allowed to just remove default 0 (zero) and leave it blank which will prevent
transitionfrom being added.Second, I have noticed that in some combinations of UI steps, help blocks were disappearing.
Now I am ensuring hide() is not called again when command and commandType are not changed (jQuery change event can be called for the same value which was mess).