Add setters for bound methods #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevemao
requested changes
Sep 24, 2016
| }, | ||
| set(value) { | ||
| Object.defineProperty(this, key, { | ||
| value: value |
There was a problem hiding this comment.
Do we still need
configurable: true,
writable: true
in the above code?
There was a problem hiding this comment.
This seems to have been abandoned. I suggest making the changes to the PR or a new PR.
|
I would love this for testing! |
This was referenced Jan 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I want to use the
@autobinddecorator with this awesome React babel plugin by @gaearonhttps://github.com/gaearon/react-transform-catch-errors
But when the page loads I get
Cannot set property render of #<Component> which has only a gettererror in the console.The fix is to add a setter (see the code).