Update to 2.29.1 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows transformed scripts to be parsed correctly for dependencies. Currently, using these options in combination with coffeeify or brfs (among others) will throw a syntax error.
Right now, ids used to reference modules in external bundles are required to correspond to actual files, but it'd be helpful if these ids could be arbitrary. This issue has been brought up in browserify#387 and browserify#472. A small change to how external modules are loaded, combined with using the mdeps filter option, allows for arbitrary external ids. This commit includes test coverage.
…on side effects in files with the same hash
…ecursive hash-aware dependency checker
|
Given that we are both (at least) ready to maintain a fork of browserify, I think it is time for a full-fledged fork? |
|
What are you thoughts on this? Do you have some new features or changes in mind? |
|
@alexgorbatchev currently
|
|
I have a Curious, do you think these changes wouldn't be accepted by substack? I feel that ideally we would want to contribute to the main source (vs actual fork). What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please update! Thank you for your work!