Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface nonStrictEs6module option #58

Closed
danvk opened this issue Mar 19, 2015 · 10 comments
Closed

Surface nonStrictEs6module option #58

danvk opened this issue Mar 19, 2015 · 10 comments

Comments

@danvk
Copy link

danvk commented Mar 19, 2015

non-strict-es6-module is a new option to jsx and react-tools transform which must be set to enable type imports in Flow. It should be possible to set this in reactify.

Or, let the user specify options to pass directly to transform so that this is never an issue again?

@TimeBomb
Copy link

TimeBomb commented Apr 8, 2015

The original pull request for this nonStrictEs6Module flag and the es6module flag can be found at facebook/react#3143, which includes specific information about them. Unfortunately not officially documented yet, so it appears.

@ezmiller
Copy link

How does one set these flags in a Grunt configuration when using browserify and reactify as a transform? I created a stackoverflow question about this.

@danvk
Copy link
Author

danvk commented Apr 12, 2015

Here's my fix: #59

@MatthewHerbst
Copy link

Any updates here? I'm running into this problem (as seen in #60 ) also.

@danvk
Copy link
Author

danvk commented Jun 26, 2015

Can you use jstransformify instead of reactify? I recently made some changes to make its interface more like reactify.

@MatthewHerbst
Copy link

@danvk When I switched my transform from

bundler.transform(reactify, {es6:true});

to

bundle.transform(jstransformify);

I get the error:

Error: while transforming /Users/mherbst/Repos/data-validation-tool/src/client/js/app.jsx:Error: Parse Error: Line 1: Illegal import declaration

@MatthewHerbst
Copy link

I was able to use babelify instead of reactify and it solved all my problems.

@andreypopp
Copy link
Owner

Yeah, reactify is pretty much deprecated now as babel is replacing jstransform.

@DannyvanderJagt
Copy link

@MatthewHerbst Thank you that worked for me too!

@alex179ohm
Copy link

@MatthewHerbst Tanks! babelify works fine for me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants