--target es5 enables es6 class getters and setters
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| options.harmony || options.es6 ? | ||
| visitors.getAllVisitors() : | ||
| visitors.transformVisitors.react); | ||
| var transformOptions = {}, transformVisitors; |
There was a problem hiding this comment.
Can we have those var definitions on different lines as separate declarations?
|
I'd better introduce |
|
I think I remember seeing that harmony transforms in jstransform already assume a target of es5? I prefer |
|
@luigy you're right about |
luigy
force-pushed
the
enable-es6-class-getters-and-setters
branch
from
e495a4f
to
45e8070
Compare
luigy
changed the title
--target es5 enables es6 class getters and setters
|
@andreypopp you're right |
andreypopp
added a commit
that referenced
this pull request
Nov 12, 2014
`--target es5` enables es6 class getters and setters
|
Thanks merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
es5 compatibility is already assumed for some of the harmony transforms so this shouldn't affect any previous behaviores6 class getters and setters require es5 as target
activate them with new option:
--target es5