Diff shows wrong elements as changed in a list of objects

[nhinds]

For some inputs, the diff shows an existing item in the list as added, and the new item as only having one field modified:

$ cat one.json
[
  { "key": "value1", "foo": "exists", "bar": "exists" }
]

$ cat two.json
[
  { "key": "value2", "foo": "new", "bar": "new" },
  { "key": "value2", "foo": "exists", "bar": "exists" }
]

$ json-diff one.json two.json
 [
   {
-    key: "value1"
+    key: "value2"
   }
+  {
+    key: "value2"
+    foo: "exists"
+    bar: "exists"
+  }
 ]

The diff above shows the { "key": "value2", "foo": "exists", "bar": "exists" } as being added, and fails to output the "new" string values at all.

If the list items are reversed in two.json, the diff output is even more wrong:

$ cat one.json
[
  { "key": "value1", "foo": "exists", "bar": "exists" }
]
$ cat two.json
[
  { "key": "value2", "foo": "exists", "bar": "exists" },
  { "key": "value2", "foo": "new", "bar": "new" }
]
$ json-diff one.json two.json
 [
   {
-    key: "value1"
+    key: "value2"
-    foo: "exists"
+    foo: "new"
-    bar: "exists"
+    bar: "new"
   }
+  {
+    key: "value2"
+    foo: "new"
+    bar: "new"
+  }
 ]

In this case, it shows the existing item as being removed, and the new item as being added twice.

[ewoudenberg]

This has been fixed in 0.6.0:

$ cat one.json two.json
[
  { "key": "value1", "foo": "exists", "bar": "exists" }
]
[
  { "key": "value2", "foo": "new", "bar": "new" },
  { "key": "value2", "foo": "exists", "bar": "exists" }
]
$ json-diff  one.json two.json
 [
+  {
+    key: "value2"
+    foo: "new"
+    bar: "new"
+  }
   {
-    key: "value1"
+    key: "value2"
   }
 ]
$ json-diff  two.json one.json
 [
-  {
-    key: "value2"
-    foo: "new"
-    bar: "new"
-  }
   {
-    key: "value2"
+    key: "value1"
   }
 ]