-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change in v0.7.2 #79
Comments
There's the additional issue (that doesn't happen to affect me here) that it uses arrow function syntax but doesn't require a node version that supports it; perhaps it'd be better to just add babel, so you don't have to worry about it in the future? Additionally, it might be good to add eslint and target the appropriate syntax level, so that CI can't pass with too-new syntax. |
Thank you @ljharb -- I've reverted usage of the ?? operator. |
We've reverted usage of the ?? operator. |
Thank you for the fast fix!! |
https://unpkg.com/browse/json-diff@0.7.2/lib/colorize.js contains the
??
operator (added in #73); v0.7.1 does not.package.json explicitly says all node versions in
engines.node
(https://unpkg.com/browse/json-diff@0.7.1/package.json), and in npm's semver, v0.8.0 would be a breaking change, but v0.7.2 can only be minor or patch.Can you publish a v0.7.3 that avoids this operator?
The text was updated successfully, but these errors were encountered: