Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch for No-diff in colored and raw json output #16

Merged
merged 1 commit into from Aug 20, 2017

Conversation

kounoike
Copy link
Contributor

json-diff 0.3.1 has problem for same inputs.

$ cat a.json
[]
$ cat b.json
[]
$ node_modules/.bin/json-diff a.json b.json
 undefined
$ node_modules/.bin/json-diff -j a.json b.json

net.js:612
    throw new TypeError('invalid data');
          ^
TypeError: invalid data
    at WriteStream.Socket.write (net.js:612:11)
    at _Class.continuation (/home/chinachu/chinachu-scripts/node_modules/json-diff/lib/cli.js:101:31)
    at _Class.iced.Deferrals._Class._fulfill (/home/chinachu/chinachu-scripts/node_modules/json-diff/lib/cli.js:16:40)
    at /home/chinachu/chinachu-scripts/node_modules/json-diff/lib/cli.js:30:24
    at fs.js:268:14
    at Object.oncomplete (fs.js:107:15)

I wrote simple patch. But I can't test my patch.
How to test my npm-module?

@andreyvit andreyvit merged commit 211b0f1 into andreyvit:master Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants